I'll create a jira and submit patch. Pre-commit job is already running with java 8. We have two post-commit jobs, one for java7 and one for java8. I'll modify jdk setting in the jenkins job of the java7 post commit job. Nothing else should be required. Please reply if I'm missing anything.
On Fri, Feb 10, 2017 at 7:54 AM Raju Bairishetti <[email protected]> wrote: > +1 > > https://builds.apache.org/job/Lens-Commit-Java8/ > <https://builds.apache.org/job/Lens-Commit-Java8/303/> job was configured > more than a year ago :). Looks like build has been passing. > > Precommit lens job is also using java8 for builds. Updated java version to > *JDK_1_8_0_92_HOME* from *JDK1_8_0_05_HOME* in pre-commit job as > JDK1_8_0_05_HOME env is not present on those machines. > > > On Thu, Feb 9, 2017 at 8:34 PM, Puneet Gupta <[email protected]> > wrote: > > > Then should we try building by setting source and target to 1.8 ? > > > > <java.source.version>1.7</java.source.version> > > <java.target.version>1.7</java.target.version> > > > > Thanks, > > Puneet Gupta > > > > On Thu, Feb 9, 2017 at 4:27 PM, amareshwarisr . <[email protected]> > > wrote: > > > > > Yes - we have latest build passed as well : > > > https://builds.apache.org/job/Lens-Commit-Java8/303/ > > > > > > On Thu, Feb 9, 2017 at 3:21 PM, Rajat Khandelwal < > [email protected] > > > > > > wrote: > > > > > > > Yeah, I suppose. We have a build jenkins job for java8. I'll try > > running > > > > tests on my local environment. > > > > > > > > On Thu, Feb 9, 2017 at 2:42 PM Puneet Gupta <[email protected] > > > > > > wrote: > > > > > > > > > Can our code compile on Java 8 in current state ? > > > > > > > > > > Thanks, > > > > > Puneet Gupta > > > > > > > > > > On Thu, Feb 9, 2017 at 2:41 PM, amareshwarisr . < > > [email protected] > > > > > > > > > wrote: > > > > > > > > > > > +1 > > > > > > > > > > > > On Thu, Feb 9, 2017 at 12:25 PM, Rajat Khandelwal < > > [email protected] > > > > > > > > > > wrote: > > > > > > > > > > > > > It's been 2 years since we said "Lens won't compile on Java 6 > > > > anymore". > > > > > > > I've used Java 8 in other places and I like the new features > and > > > > > > > capabilities and I think we can make use of them to make our > > > complex > > > > > code > > > > > > > smaller and easier to understand. To do that, we'd need to stop > > > > > > supporting > > > > > > > compilation on Java 7, which I believe is fine seeing as Java 7 > > has > > > > > been > > > > > > > EOL for a couple of years now. > > > > > > > > > > > > > > Thoughts? > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > _____________________________________________________________ > > > > > The information contained in this communication is intended solely > > for > > > > the > > > > > use of the individual or entity to whom it is addressed and others > > > > > authorized to receive it. It may contain confidential or legally > > > > privileged > > > > > information. If you are not the intended recipient you are hereby > > > > notified > > > > > that any disclosure, copying, distribution or taking any action in > > > > reliance > > > > > on the contents of this information is strictly prohibited and may > be > > > > > unlawful. If you have received this communication in error, please > > > notify > > > > > us immediately by responding to this email and then delete it from > > your > > > > > system. The firm is neither liable for the proper and complete > > > > transmission > > > > > of the information contained in this communication nor for any > delay > > in > > > > its > > > > > receipt. > > > > > > > > > > > > > > > > -- > > _____________________________________________________________ > > The information contained in this communication is intended solely for > the > > use of the individual or entity to whom it is addressed and others > > authorized to receive it. It may contain confidential or legally > privileged > > information. If you are not the intended recipient you are hereby > notified > > that any disclosure, copying, distribution or taking any action in > reliance > > on the contents of this information is strictly prohibited and may be > > unlawful. If you have received this communication in error, please notify > > us immediately by responding to this email and then delete it from your > > system. The firm is neither liable for the proper and complete > transmission > > of the information contained in this communication nor for any delay in > its > > receipt. > > > > > > -- > > ------ > Thanks, > Raju Bairishetti, > www.lazada.com >
