----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/#review166068 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java (line 230) <https://reviews.apache.org/r/56842/#comment237964> Can we fix TODO lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java (line 748) <https://reviews.apache.org/r/56842/#comment237965> Unused ? lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java (line 751) <https://reviews.apache.org/r/56842/#comment237966> unused ? lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java (line 303) <https://reviews.apache.org/r/56842/#comment237977> can we update the message to replace fact with storage. Also can we log max interval in this message . lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java (line 305) <https://reviews.apache.org/r/56842/#comment237978> Should we rename QUERY_INTERVAL_BIGGER_THAN_MAX to UPDATE_PERIOD_BIGGER_THAN_MAX ? lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java (line 310) <https://reviews.apache.org/r/56842/#comment237979> It seems wrong to prune an undate period if it can not cover a time range . We shuld keep it if it can partially cover a time range. Example Month + Day can cover time Range . Month alone can not cover the time range. lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java (line 313) <https://reviews.apache.org/r/56842/#comment237980> Should we call this QUERY_INTERVAL_SMALLER_THAN_UPDATE_PERIOD ? - Puneet Gupta On Feb. 20, 2017, 9:17 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56842/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2017, 9:17 a.m.) > > > Review request for lens. > > > Bugs: LENS-1389 > https://issues.apache.org/jira/browse/LENS-1389 > > > Repository: lens > > > Description > ------- > > This is causing test failure in lens-1381 branch. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java > 771708132a7e9dfbcb1148329647a946425b9d42 > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java > bf6cc5c3e6d8fc6521a5b0f1ef3e0212f0111c7a > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > c7f2047b57ebc26244891d9bc48ad18ab0176fdd > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > fca86ec88b1dd0507d21ca1b414dcc6fb68317e3 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 3029589ae1db24330aebb6eaa34aa127c3576a04 > pom.xml 8ea64b77fff11d9f46be56437aed3b527bde0ff8 > > Diff: https://reviews.apache.org/r/56842/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
