----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57948/#review170142 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java Line 2102 (original), 2102 (patched) <https://reviews.apache.org/r/57948/#comment242932> Should this be the other way, if return false if any of the tables do not contain the partition column? - Amareshwari Sriramadasu On March 27, 2017, 8:40 a.m., Puneet Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57948/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 8:40 a.m.) > > > Review request for lens. > > > Bugs: LENS-1397 > https://issues.apache.org/jira/browse/LENS-1397 > > > Repository: lens > > > Description > ------- > > Consider the case where a Storage S has three update periods and each update > period has a different table description "table_desc" as supported in > LENS-1386. > > We should be able to rewrite queries for such storages > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 78fb6d3a49ec7c5d407267d835bdfc83a6fd0cc2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java > 5bdbf74c4171badbefe5bc07e9ae557b100b0abb > lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java > 095a2976db5c1d456b7ab3b4ca95b6cac9172172 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java > 0b7d4002bb9390b364e1b4aeb78ae9f0eb523d25 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 6cb18e629011de17d8c12a0bac0fc6e9110c7186 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 97a73a8059d816eb2f35b313f74c7a04aa60e49c > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > 68449f667782c15802ed211b51a91f208471f058 > > lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnLifetimeChecker.java > 24eb8f05d250dfecb41afc4a4eb8f031b90850d8 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 76031ecbadec307a12fe172f7b227b9f292e642f > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java > 0e2ca821ba8eb7c3b4eeb029ac88422091781a48 > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java > 17e202d5eeeaa75bc985372a05a8589ac9271626 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > bcea7ed4d39639e66f699500f24b79dc280d3906 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 1daeea53955d121abfe94eaae2979bb1cbc8eca5 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java > fa3ba8f982b35eb3c79afd76284b698f09558a4e > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > 4cae6f8074641574859b8d2782ac3afa11d6e441 > lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java > bdd6376373b50c3e2c1606e69eeac75d186d6af2 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 25acb01a94b4103806eccac539d16bc1b12761dd > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > bc008ae6181490909605488a618029b8b6086f3c > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java > d97e7b8d499393a1cb5122126bd97637c1bd2b58 > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java > 2ca11819166c3b6de10d0ff63eed4eb4c501ff5b > > lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java > b5b0b30426bb9d5761108e4d09ace970e8b1b9d5 > lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java > 3bdc047c37f3e4425277db579c80ceb1cb89a6b2 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 94d4b40ee33fc8c81904d5979bc6cc8cfe599e24 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 2bf0554cd016cb581a1dcfa6220980a03d8777ff > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > 523a8768cc917bab95cf8f2bd9ff57a1a6f6e24c > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryMetrics.java > 46ee863e71a3444abbc1365243d6014017e30014 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java > cd7383bca91c072c30a5bc4207369288d7cb0a76 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java > a6b8f889c26f38c2c94f35e2752b1779b6a1ec4d > lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java > c2d5f7c3202d0472ff06c3065f359964c0f1217c > > > Diff: https://reviews.apache.org/r/57948/diff/1/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Building Lens Cube 2.7.0-SNAPSHOT > [INFO] > ------------------------------------------------------------------------ > [INFO] > [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ lens-cube --- > [INFO] > [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ lens-cube --- > [INFO] > [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ > lens-cube --- > [INFO] Using 'UTF-8' encoding to copy filtered resources. > [INFO] skip non existing resourceDirectory > /d0/jenkins/workspace/Platform_Common_Job/lens-cube/src/deb/control > [INFO] Copying 1 resource > [INFO] Copying 3 resources > [INFO] > [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ lens-cube --- > [INFO] Changes detected - recompiling the module! > [INFO] Compiling 119 source files to > /d0/jenkins/workspace/Platform_Common_Job/lens-cube/target/classes > [WARNING] > /d0/jenkins/workspace/Platform_Common_Job/lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java: > Some input files use or override a deprecated API. > [WARNING] > /d0/jenkins/workspace/Platform_Common_Job/lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java: > Recompile with -Xlint:deprecation for details. > [WARNING] > /d0/jenkins/workspace/Platform_Common_Job/lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java: > Some input files use unchecked or unsafe operations. > [WARNING] > /d0/jenkins/workspace/Platform_Common_Job/lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java: > Recompile with -Xlint:unchecked for details. > [INFO] > [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ > lens-cube --- > [INFO] Using 'UTF-8' encoding to copy filtered resources. > [INFO] Copying 2 resources > [INFO] Copying 3 resources > [INFO] > [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ > lens-cube --- > [INFO] Changes detected - recompiling the module! > [INFO] Compiling 41 source files to > /d0/jenkins/workspace/Platform_Common_Job/lens-cube/target/test-classes > [WARNING] > /d0/jenkins/workspace/Platform_Common_Job/lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java: > > /d0/jenkins/workspace/Platform_Common_Job/lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java > uses or overrides a deprecated API. > [WARNING] > /d0/jenkins/workspace/Platform_Common_Job/lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java: > Recompile with -Xlint:deprecation for details. > [INFO] > [INFO] --- maven-surefire-plugin:2.15:test (default-test) @ lens-cube --- > [INFO] Surefire report directory: > /d0/jenkins/workspace/Platform_Common_Job/lens-cube/target/surefire-reports > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; > support was removed in 8.0 > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; > support was removed in 8.0 > Running TestSuite > Tests run: 418, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 299.41 sec > - in TestSuite > > Results : > > Tests run: 418, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Puneet Gupta > >
