-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57236/
-----------------------------------------------------------

(Updated March 27, 2017, 2:38 p.m.)


Review request for lens.


Bugs: LENS-1398
    https://issues.apache.org/jira/browse/LENS-1398


Repository: lens


Description
-------

If lens api gives error, then the lensAPIResult object in response is ignored.


Diffs (updated)
-----

  contrib/clients/python/lens/client/main.py 
1e9d88fbcc63b0d10ce1adb2f6ef128e7c0e418c 


Diff: https://reviews.apache.org/r/57236/diff/5/

Changes: https://reviews.apache.org/r/57236/diff/4-5/


Testing
-------

$ mci -Ppy
  [INFO] Scanning for projects...
  [INFO] 
------------------------------------------------------------------------
  [INFO] Reactor Build Order:
  [INFO] Lens Contrib
  [INFO] Lens Contributed Clients
  [INFO] Lens Python Client
  [INFO] 
------------------------------------------------------------------------
  [INFO] Building Lens Contrib 2.7.0-SNAPSHOT
  [INFO] 
------------------------------------------------------------------------
  [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ lens-contrib ---
  [INFO] Deleting /Users/rajat.khandelwal/Git/lens/contrib/target
  [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ lens-contrib 
---
  [INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ 
lens-contrib ---
  [INFO] 52 implicit excludes (use -debug for more details).
  [INFO] 1 resources included (use -debug for more 
details)entityExpansionLimit' is not recognized.
  [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
lens-contrib ---
  [INFO] Installing /Users/rajat.khandelwal/Git/lens/contrib/pom.xml to 
/Users/rajat.khandelwal/.m2/repository/org/apache/lens/lens-contrib/2.7.0-SNAPSHOT/lens-contrib-2.7.0-SNAPSHOT.pom
  [INFO] 
------------------------------------------------------------------------
  [INFO] Building Lens Contributed Clients 2.7.0-SNAPSHOT
  [INFO] 
------------------------------------------------------------------------
  [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
lens-contrib-clients ---
  [INFO] Deleting /Users/rajat.khandelwal/Git/lens/contrib/clients/target
  [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
lens-contrib-clients ---
  [INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ 
lens-contrib-clients ---
  [INFO] 52 implicit excludes (use -debug for more details).
  [INFO] 1 resources included (use -debug for more 
details)entityExpansionLimit' is not recognized.
  [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
lens-contrib-clients ---
  [INFO] Installing /Users/rajat.khandelwal/Git/lens/contrib/clients/pom.xml to 
/Users/rajat.khandelwal/.m2/repository/org/apache/lens/lens-contrib-clients/2.7.0-SNAPSHOT/lens-contrib-clients-2.7.0-SNAPSHOT.pom
  [INFO] 
------------------------------------------------------------------------
  [INFO] Building Lens Python Client 2.7.0-SNAPSHOT
  [INFO] 
------------------------------------------------------------------------
  [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ lens-python-client 
---
  [INFO] Deleting /Users/rajat.khandelwal/Git/lens/contrib/clients/python/target
  [INFO] --- exec-maven-plugin:1.2.1:exec (setuptools clean) @ 
lens-python-client ---
  running clean
  'build/lib' does not exist -- can't clean it
  'build/bdist.macosx-10.10-x86_64' does not exist -- can't clean it
  'build/scripts-2.7' does not exist -- can't clean it
  [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
lens-python-client ---
  [INFO] --- exec-maven-plugin:1.2.1:exec (setuptools install) @ 
lens-python-client ---
  running develop
  running egg_info
  writing requirements to lens_client.egg-info/requires.txt
  writing lens_client.egg-info/PKG-INFO
  writing top-level names to lens_client.egg-info/top_level.txt
  writing dependency_links to lens_client.egg-info/dependency_links.txt
  reading manifest file 'lens_client.egg-info/SOURCES.txt'
  reading manifest template 'MANIFEST.in'
  writing manifest file 'lens_client.egg-info/SOURCES.txt'
  running build_ext
  Creating /usr/local/lib/python2.7/site-packages/lens-client.egg-link (link to 
.)
  lens-client 2.6.1 is already the active version in easy-install.pth

  Installed /Users/rajat.khandelwal/Git/lens/contrib/clients/python
  Processing dependencies for lens-client==2.6.1
  Searching for six==1.10.0
  Best match: six 1.10.0
  Adding six 1.10.0 to easy-install.pth file

  Using /Library/Python/2.7/site-packages
  Searching for requests==2.10.0
  Best match: requests 2.10.0
  Adding requests 2.10.0 to easy-install.pth file

  Using /usr/local/lib/python2.7/site-packages
  Finished processing dependencies for lens-client==2.6.1
  [INFO] --- exec-maven-plugin:1.2.1:exec (setuptools test) @ 
lens-python-client ---
  running test
  running egg_info
  writing requirements to lens_client.egg-info/requires.txt
  writing lens_client.egg-info/PKG-INFO
  writing top-level names to lens_client.egg-info/top_level.txt
  writing dependency_links to lens_client.egg-info/dependency_links.txt
  reading manifest file 'lens_client.egg-info/SOURCES.txt'
  reading manifest template 'MANIFEST.in'
  writing manifest file 'lens_client.egg-info/SOURCES.txt'
  running build_ext
  
/Users/rajat.khandelwal/Git/lens/contrib/clients/python:/Library/Python/2.7/site-packages:/usr/local/lib/python2.7/site-packages:/usr/local/lib/python2.7/site-packages:/usr/local/lib/python2.7/site-packages:/usr/local/lib/python2.7/site-packages:/Library/Python/2.7/site-packages
  None
  GLOB sdist-make: 
/Users/rajat.khandelwal/Git/lens/contrib/clients/python/setup.py
  py27 inst-nodeps: 
/Users/rajat.khandelwal/Git/lens/contrib/clients/python/.tox/dist/lens-client-2.6.1.zip
  py27 installed: 
appdirs==1.4.3,lens-client==2.6.1,packaging==16.8,pyparsing==2.2.0,six==1.10.0
  py27 runtests: PYTHONHASHSEED='1205842367'
  py27 runtests: commands[0] | py.test
  ============================= test session starts 
==============================
  platform darwin -- Python 2.7.10, pytest-2.9.1, py-1.4.31, pluggy-0.3.1
  rootdir: /Users/rajat.khandelwal/Git/lens/contrib/clients/python, inifile: 
tox.ini
  collected 9 items

  lens/client/utils.py ..
  test/test_lensclient.py  .......

  ========================== 9 passed in 113.27 seconds 
==========================
  py35 inst-nodeps: 
/Users/rajat.khandelwal/Git/lens/contrib/clients/python/.tox/dist/lens-client-2.6.1.zip
  py35 installed: 
/Users/rajat.khandelwal/Git/lens/contrib/clients/python/.tox/py35/bin/../lib/python3.5/site.py:165:
 DeprecationWarning: 'U' mode is deprecated,  f = open(fullname, 
"rU"),/Users/rajat.khandelwal/Git/lens/contrib/clients/python/.tox/py35/lib/python3.5/distutils/__init__.py:4:
 PendingDeprecationWarning: the imp module is deprecated in favour of 
importlib; see the module's documentation for alternative uses,  import 
imp,appdirs==1.4.3,coverage==4.3.4,lens-client==2.6.1,packaging==16.8,py==1.4.33,pyparsing==2.2.0,pytest==3.0.7,pytest-cov==2.4.0,requests==2.13.0,six==1.10.0
  py35 runtests: PYTHONHASHSEED='1205842367'
  py35 runtests: commands[0] | py.test
  ============================= test session starts 
==============================
  platform darwin -- Python 3.5.1, pytest-3.0.7, py-1.4.33, pluggy-0.4.0
  rootdir: /Users/rajat.khandelwal/Git/lens/contrib/clients/python, inifile: 
tox.ini
  plugins: cov-2.4.0
  collected 9 items

  lens/client/utils.py ..
  test/test_lensclient.py .......

  ========================== 9 passed in 210.48 seconds 
==========================
  
/Users/rajat.khandelwal/Git/lens/contrib/clients/python/.tox/py35/bin/../lib/python3.5/site.py:165:
 DeprecationWarning: 'U' mode is deprecated
    f = open(fullname, "rU")
  
/Users/rajat.khandelwal/Git/lens/contrib/clients/python/.tox/py35/lib/python3.5/site-packages/_pytest/assertion/rewrite.py:7:
 PendingDeprecationWarning: the imp module is deprecated in favour of 
importlib; see the module's documentation for alternative uses
    import imp
  ___________________________________ summary 
____________________________________
    py27: commands succeeded
    py35: commands succeeded
    congratulations :)
  [INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ 
lens-python-client ---
  [INFO] 51 implicit excludes (use -debug for more details).
  [INFO] 32 resources included (use -debug for more 
details)entityExpansionLimit' is not recognized.
  [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
lens-python-client ---
  [INFO] Installing 
/Users/rajat.khandelwal/Git/lens/contrib/clients/python/pom.xml to 
/Users/rajat.khandelwal/.m2/repository/org/apache/lens/lens-python-client/2.7.0-SNAPSHOT/lens-python-client-2.7.0-SNAPSHOT.pom
  [INFO] 
------------------------------------------------------------------------
  [INFO] Reactor Summary:
  [INFO] Lens Contrib ....................................... SUCCESS [  6.849 
s]
  [INFO] Lens Contributed Clients ........................... SUCCESS [  0.906 
s]
  [INFO] Lens Python Client ................................. SUCCESS [05:34 
min]
  [INFO] 
------------------------------------------------------------------------
  [INFO] BUILD SUCCESS
  [INFO] 
------------------------------------------------------------------------
  [INFO] Total time: 05:42 min
  [INFO] Finished at: 2017-03-21T16:03:44+05:30
  [INFO] Final Memory: 29M/493M
  [INFO] 
------------------------------------------------------------------------
  rajat.khandelwal@IM1258-X1:~/Git/lens/contrib [0]
  $


Thanks,

Rajat Khandelwal

Reply via email to