----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58338/#review171672 -----------------------------------------------------------
lens-api/src/main/resources/lens-errors.conf Line 331 (original), 337 (patched) <https://reviews.apache.org/r/58338/#comment244690> New error should moved inside this. lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java Lines 65 (patched) <https://reviews.apache.org/r/58338/#comment244689> Can you change the number to 3105 ? lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java Lines 1958 (patched) <https://reviews.apache.org/r/58338/#comment244688> Can you update test for verfiying the error as well? - Amareshwari Sriramadasu On April 11, 2017, 11:58 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58338/ > ----------------------------------------------------------- > > (Updated April 11, 2017, 11:58 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-1410 > https://issues.apache.org/jira/browse/LENS-1410 > > > Repository: lens > > > Description > ------- > > A string filer for getting for partition api must tbe provided > > > Diffs > ----- > > lens-api/src/main/resources/lens-errors.conf 29e24cf > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > 571b481 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 9d823da > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > f6f6e77 > > > Diff: https://reviews.apache.org/r/58338/diff/2/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
