----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57947/#review172464 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java Line 271 (original), 271 (patched) <https://reviews.apache.org/r/57947/#comment245588> This looks a wrong assignment of storageTable to storageName. - Amareshwari Sriramadasu On April 19, 2017, 1:36 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57947/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 1:36 p.m.) > > > Review request for lens. > > > Bugs: LENS-974 > https://issues.apache.org/jira/browse/LENS-974 > > > Repository: lens > > > Description > ------- > > With cube segmentation a cube can have multiple cubes and all these child > cubes together will make the cube complete. > > CubeSegmentation and CubeFactTable will sit together, which means it can > belong to only one base cube. A base cube can have one or more cube > segmentations. Fields of segmentation will be intersection of all columns of > its cubes. Segmentation will have weight to compare with its buddies (facts > or other segmentations). Also it can have start and end time defined or it > can derive from its underline facts. > > eg: > base_cube > |_fact1 > |_fact2 > |_cube_segment1 > |_cube1 > |_fact_11 > |_fact_12 > ... > ... > |_cube_segment2 > |_cube2 > |_fact_21 > |_fact_22 > ... > ... > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/ds/Tuple2.java PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java > 21dda1685e8211357b0e35884ab3a96800451e9e > lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java > b376aaf463f991c540b7c711a90271551848a6e2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java > 99ad2331dc68d893703523ea4f0511333cb7b837 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 599027fbc32bace298d58b0797f2585d627115e2 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java > 2e85111583eb8d80427df91607411581d4ccd38c > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java > 82868949e9fbf38046548a6a32c7406f81b2dcfa > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 > lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java > f241cb3111426f820beffe7c63209162bfb50f39 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java > b22d9729252a9bb389e881032f63a950510c4081 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateSegmentResolver.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > b9ff0eff271c62020800b9309a223f4f0db8d296 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > 300d798f9dd5760853d86d106ec2b9fc1e91afb5 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > c63c4c0f2204591521f44584239fc9e275a60649 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > 6bee3864e26a83c695e9389f8cbf6d93ca3fa37c > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java > 29da0a2cf64f28cd1dbd2d52cc6609aaefc07a50 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 30fa873c255df408563f3c20062a6ccfca0f3811 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 95d65728457d24ac58fcaedc0d4c7a9b2e71fd71 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 6f6572ea3ba5ae5c6cb7ad2bc0eb9ce058f0ccc2 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 926a4d0e0eaead318be64e37c2d3950d7b883fcb > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > 1b30c0b25d3ac861fa289f699421d4e420195b50 > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java > 78d448ab1d145925ebfe27bb86333c8a971339ae > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > 8a70535203f038b07f387b20adf7343e593d899d > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java > 52085ea35a0ba0df61742167457ba08ae410411f > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 02e3dc7b6b93a108b1a239e4a7d01460df2666b4 > > lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java > a9bd164b8f6d9e8b27396d491dace56eef3248c3 > > lens-cube/src/main/java/org/apache/lens/cube/parse/MultiCandidateQueryWriterContext.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java > 0996db52322582a141af45137a030b108dbaa0a3 > > lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java > 310a655cd2102ce7c8da19ae3301cf9b241caff4 > lens-cube/src/main/java/org/apache/lens/cube/parse/QueryWriter.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/QueryWriterContext.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java > 77ebe82fa62d85af03d55d6a1772b08171274fd1 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > d95cf273e2ce300ec21201c52953f1c96d214be0 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 10c3bbe5a62723fab16c4e8f5381306ae31058e4 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java > f5cd540e46a68e5fb2fc4dd59f1ee6a9ec380693 > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java > 7f07dbc84916b9163ae23bb49585f1631336af20 > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java > 3ee817fc2fd1043e7315ba76ce18c05ae1ff50c8 > > lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java > aab671e2385cd92b50b344bd1a60871cf8c24173 > > lens-cube/src/main/java/org/apache/lens/cube/parse/join/BridgeTableJoinContext.java > ab5c4f9bda147385c65ee9ce1bf9349383df2021 > lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java > 432525270966a203ab0f75e47f8d1aa48704d835 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 3a174990cc290fba2688ffc61433a35583646614 > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java > 8b3b4baacd2b7b08db37c321f5aff06e28ca8df1 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 033264c81e94d1871eddea1045171042b3514e77 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 93dbfc3f3f067a843dda3243520f06e0e8c7e4b7 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > bab1080f02348190bb2a78e622f639db470a0cd6 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java > PRE-CREATION > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > d97c0e65260aee2fcd7053b1fc4a9779845fefa7 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java > 3165d3ad7019d2973c901e6179cb76504d061139 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > f5ddf7bba365a6313860191a0609ab0e729d4d67 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryMetrics.java > 3883beed7bf123d01ffc31d9d27b0b1d0a79331a > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java > 17a8b0f75a777f55a5c7ba930c3e441351b7c434 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java > d3938c1302c8600a7e4397dd5e9b8c38be2ee231 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java > bed1e7aea275cf6101e172c8132b313fcbdd27b7 > lens-cube/src/test/resources/schema/cubes/base/b1cube.xml PRE-CREATION > lens-cube/src/test/resources/schema/cubes/base/b2cube.xml PRE-CREATION > lens-cube/src/test/resources/schema/cubes/base/basecube.xml > 22703ab59360804eb31cf7c97104dfc2223bfd32 > lens-cube/src/test/resources/schema/cubes/base/testcube.xml > 2edf419b9a261c13323a42de8026da1dc46d5281 > lens-cube/src/test/resources/schema/facts/b1b2fact1.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/b1fact1.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/b2fact1.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact2.xml > 41d2045004f9f9066f37e93916f1b67ce0074d2e > lens-cube/src/test/resources/schema/facts/union_join_ctx_fact1.xml > fcef02d62fa2e065016f5129e51893ca6d1446f1 > lens-cube/src/test/resources/schema/segmentations/seg1.xml > 7ed48a1ca97176e59b5481ad57c864e3675d89bd > > lens-server-api/src/test/java/org/apache/lens/server/api/query/comparators/ChainedComparatorTest.java > cc587519dda64036ba56c15690d12c9b57c0afc6 > > > Diff: https://reviews.apache.org/r/57947/diff/12/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
