----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58604/#review172619 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java Lines 1716 (patched) <https://reviews.apache.org/r/58604/#comment245704> Not sure if logging the driver name makes sense. Also Should we log this as error or warning is debatable ? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java Lines 1722 (patched) <https://reviews.apache.org/r/58604/#comment245702> can we use for(RewriteEstimateRunnable r : runnables) instead ? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java Lines 1727 (patched) <https://reviews.apache.org/r/58604/#comment245703> Alsoe we can add a sugestion to "Please try again later". - Puneet Gupta On April 21, 2017, 7:25 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58604/ > ----------------------------------------------------------- > > (Updated April 21, 2017, 7:25 a.m.) > > > Review request for lens. > > > Bugs: LENS-1413 > https://issues.apache.org/jira/browse/LENS-1413 > > > Repository: lens > > > Description > ------- > > 1. Cancel estimates for other drivers when the estimate pool queue is full. > 2. Return the appropriate error message > > > Diffs > ----- > > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 92724c6 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c6fbeda > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 7d8c977 > lens-server/src/test/resources/lens-site.xml 334a9c4 > > > Diff: https://reviews.apache.org/r/58604/diff/1/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
