> On May 25, 2017, 9:58 a.m., Amareshwari Sriramadasu wrote: > > lens-api/src/main/resources/cube-0.1.xsd > > Lines 1226 (patched) > > <https://reviews.apache.org/r/58796/diff/10/?file=1727017#file1727017line1296> > > > > should we say columns and storages
will do > On May 25, 2017, 9:58 a.m., Amareshwari Sriramadasu wrote: > > lens-api/src/main/resources/cube-0.1.xsd > > Lines 1256 (patched) > > <https://reviews.apache.org/r/58796/diff/10/?file=1727017#file1727017line1326> > > > > Shall we move properties to x_fact ? Can't move it as existing schema order will have to change > On May 25, 2017, 9:58 a.m., Amareshwari Sriramadasu wrote: > > lens-api/src/main/resources/cube-0.1.xsd > > Lines 1290 (patched) > > <https://reviews.apache.org/r/58796/diff/10/?file=1727017#file1727017line1360> > > > > Should we move weight to x_fact ? Weight is optional in virtual and mandatory in base..so din't move it to x fact - Rajitha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review176051 ----------------------------------------------------------- On June 2, 2017, 9:41 a.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58796/ > ----------------------------------------------------------- > > (Updated June 2, 2017, 9:41 a.m.) > > > Review request for lens, Rajat Khandelwal and Puneet Gupta. > > > Repository: lens > > > Description > ------- > > CRUD changes and Unit test cases for Virtual Fact > > > Diffs > ----- > > checkstyle/pom.xml 2902c6b > contrib/clients/python/pom.xml ac842bd > lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java > 9564443 > lens-api/src/main/resources/cube-0.1.xsd 8158e6d > lens-api/src/main/resources/lens-errors.conf 43de1e9 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > a01d6c0 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java > 20f313a > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > d31e25c > lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java > ca6db2c > lens-cli/src/test/resources/schema/cubes/base/virtual-cube.xml PRE-CREATION > lens-cli/src/test/resources/schema/facts/virtual_fact.xml PRE-CREATION > lens-client/src/main/java/org/apache/lens/client/LensClient.java 4f8da06 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > f077c9c > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > 32b9db3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > 67aaff8 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 88bc1fc > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b5c4c89 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > e1e3d16 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 88500fd > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 40f766b > lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java > 1e3cef3 > lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > a8d6fbd > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > 6ba46d6 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 47bce65 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 43510dd > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java > 038d689 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 1e54f13 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java > 730b802 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 291712b > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java > 6c0d91a > > lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java > 42e32cb > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > a76ef13 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 2f300d3 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 7d1f80d > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java > fe52600 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java > 7ec3324 > lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION > lens-dist/src/deb/control/postinst PRE-CREATION > lens-driver-es/pom.xml 925020e > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > 75153f6 > lens-driver-jdbc/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml > ac5e43d > lens-examples/pom.xml af467ee > lens-examples/src/test/resources/yaml/fact1.yaml 9c1c527 > lens-examples/src/test/resources/yaml/fact2.yaml 6fadd11 > lens-examples/src/test/resources/yaml/rawfact.yaml f7b2d55 > lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml > f95f91b > lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml 02f65ff > lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml ff47d36 > lens-examples/src/test/resources/yaml/sales-raw-fact.yaml 15becfc > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 28b9d22 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java > 2667ebf > lens-server/pom.xml 60ed1ae > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 194b380 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7451aa9 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 6d32d23 > pom.xml af7dafa > src/site/apt/user/cli.apt fce41fe > tools/scripts/generate-site-public.sh 109268c > > > Diff: https://reviews.apache.org/r/58796/diff/12/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s] > [INFO] Lens .............................................. SUCCESS [3.449s] > [INFO] Lens API .......................................... SUCCESS [23.572s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.051s] > [INFO] Lens Cube ......................................... SUCCESS [5:41.995s] > [INFO] Lens DB storage ................................... SUCCESS [17.013s] > [INFO] Lens Query Library ................................ SUCCESS [13.632s] > [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s] > [INFO] Lens Server ....................................... SUCCESS > [16:38.220s] > [INFO] Lens client ....................................... SUCCESS [1:25.658s] > [INFO] Lens CLI .......................................... SUCCESS [1:16.332s] > [INFO] Lens Examples ..................................... SUCCESS [8.432s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s] > [INFO] Lens Distribution ................................. SUCCESS [9.499s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s] > [INFO] Lens Regression ................................... SUCCESS [12.136s] > [INFO] Lens UI ........................................... SUCCESS [32.999s] > [INFO] Lens Contrib ...................................... SUCCESS [0.358s] > [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s] > [INFO] Lens Python Client ................................ SUCCESS [0.366s] > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajitha R > >