----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60364/#review178658 -----------------------------------------------------------
Ship it! Ship It! - Sushil Mohanty On June 22, 2017, 11:09 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60364/ > ----------------------------------------------------------- > > (Updated June 22, 2017, 11:09 a.m.) > > > Review request for lens. > > > Bugs: LENS-1444 > https://issues.apache.org/jira/browse/LENS-1444 > > > Repository: lens > > > Description > ------- > > Current algorithm is given {{n}} candidates, first find {{2 ^n^ -1}} union > candidates using power set and then among them, remove the ones which don't > cover the queried time range(s). > > Proposed optimization: Pushdown of the prune logic. We'll not create a list > of {{2 ^n^ -1}} candidates, we'll check for coverability before adding it as > an eligible union candidate. This will bring down the number of > {{UnionCandidates}} in the memory and preventing Full-GC. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java > 61c28c6903b2029165df5d894b5b01ebd779405c > > > Diff: https://reviews.apache.org/r/60364/diff/1/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
