----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61881/#review189159 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java Lines 432 (patched) <https://reviews.apache.org/r/61881/#comment266089> Won't this cause issues While reading sessions back? As the count of sessions persisted is written as `SESSION_MAP.size()`. It'll try to read that many session objects. What will happen if some of the sessions are not written at all? - Rajat Khandelwal On Oct. 17, 2017, 5:37 p.m., Ankit Kailaswar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61881/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2017, 5:37 p.m.) > > > Review request for lens and Puneet Gupta. > > > Bugs: LENS-1461 > https://issues.apache.org/jira/browse/LENS-1461 > > > Repository: lens > > > Description > ------- > > Persist process for Session service should not fail if any session in > invalid. Persist service should ignore these session and continue persisting > state of other session instead of failing. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > b480d140 > > > Diff: https://reviews.apache.org/r/61881/diff/2/ > > > Testing > ------- > > > Thanks, > > Ankit Kailaswar > >
