-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/#review194536
-----------------------------------------------------------




lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 234 (patched)
<https://reviews.apache.org/r/64779/#comment273359>

    should we return or add the missing user to SESSION_USER_INSTANCE_MAP ?



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Line 342 (original), 349 (patched)
<https://reviews.apache.org/r/64779/#comment273360>

    Is this inconsistnecy coming due to a restart ? Can we handle this on 
restart itself in that case when session service boots up


- Puneet Gupta


On Dec. 21, 2017, 3:40 p.m., Rajitha R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64779/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2017, 3:40 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1497
>     https://issues.apache.org/jira/browse/LENS-1497
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> NPE fix in closing idle connections
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> d7ce434 
> 
> 
> Diff: https://reviews.apache.org/r/64779/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Reply via email to