----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66730/#review201618 -----------------------------------------------------------
lens-driver-hive/src/main/resources/hivedriver-default.xml Lines 28 (patched) <https://reviews.apache.org/r/66730/#comment282943> Can you follow the convention for hive driver properties and lens.driver.hive. ? Also add description for property ? Can you check-in hivedriver-config.apt as well ? http://lens.apache.org/developer/contribute.html#How_to_update_the_config_docs - will help you. lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java Lines 742 (patched) <https://reviews.apache.org/r/66730/#comment282944> Can you use DRIVER_PFX instead of SERVER_PFX? - Amareshwari Sriramadasu On April 20, 2018, 8:41 a.m., Ankit Kailaswar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66730/ > ----------------------------------------------------------- > > (Updated April 20, 2018, 8:41 a.m.) > > > Review request for lens and Rajitha R. > > > Bugs: Lens-1510 > https://issues.apache.org/jira/browse/Lens-1510 > > > Repository: lens > > > Description > ------- > > since the property name for lens and hive's principal name are conflicting we > need explicitly need to mention hive's principal while creating hive driver > for lens. (https://issues.apache.org/jira/browse/LENS-1510) > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 3fd5d2c6 > lens-driver-hive/src/main/resources/hivedriver-default.xml 2b2dc0bf > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0e05d28e > tools/conf/server/drivers/hive/hive1/hivedriver-site.xml 2e8e7fa8 > > > Diff: https://reviews.apache.org/r/66730/diff/3/ > > > Testing > ------- > > build logs... > [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-check) @ > lens-python-client --- > [INFO] Starting audit... > Audit done. > [INFO] > [INFO] >>> findbugs-maven-plugin:3.0.1:check (findbugs-check) > :findbugs @ > lens-python-client >>> > [INFO] > [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ > lens-python-client --- > [INFO] > [INFO] <<< findbugs-maven-plugin:3.0.1:check (findbugs-check) < :findbugs @ > lens-python-client <<< > [INFO] > [INFO] > [INFO] --- findbugs-maven-plugin:3.0.1:check (findbugs-check) @ > lens-python-client --- > [INFO] > [INFO] --- maven-source-plugin:3.0.1:jar-no-fork (attach-sources) @ > lens-python-client --- > [INFO] > [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ > lens-python-client --- > [INFO] Installing > /Users/ankit.kailaswar/inmobi/apache/lens/contrib/clients/python/pom.xml to > /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.438 > s] > [INFO] Lens ............................................... SUCCESS [ 3.405 > s] > [INFO] Lens API ........................................... SUCCESS [ 24.673 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 15.839 > s] > [INFO] Lens Cube .......................................... SUCCESS [ 40.093 > s] > [INFO] Lens DB storage .................................... SUCCESS [ 10.662 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 14.807 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [ 11.680 > s] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 26.981 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 11.728 > s] > [INFO] Lens Server ........................................ SUCCESS [01:05 > min] > [INFO] Lens client ........................................ SUCCESS [ 18.802 > s] > [INFO] Lens CLI ........................................... SUCCESS [ 15.882 > s] > [INFO] Lens Examples ...................................... SUCCESS [ 9.430 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.919 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 21.463 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [ 15.604 > s] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.224 > s] > [INFO] Lens Regression .................................... SUCCESS [ 12.101 > s] > [INFO] Lens UI ............................................ SUCCESS [ 8.237 > s] > [INFO] Lens Contrib ....................................... SUCCESS [ 0.439 > s] > [INFO] Lens Contributed Clients ........................... SUCCESS [ 0.416 > s] > [INFO] Lens Python Client ................................. SUCCESS [ 0.465 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 05:35 min > [INFO] Finished at: 2018-04-20T14:03:07+05:30 > [INFO] Final Memory: 239M/1771M > [INFO] > ------------------------------------------------------------------------ > > > lens server logs.... > > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.driver.hive.HiveDriver - Hive driver hive/hive1 configured > successfully > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.server.query.QueryExecutionServiceImpl - Driver hive1 for > type hive is loaded > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.driver.hive.HiveDriver - Hive driver inited > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] WARN > org.apache.hadoop.hive.conf.HiveConf - HiveConf of name > hive.server2.authentication.ldap.security.protocol does not exist > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] WARN > org.apache.hadoop.hive.conf.HiveConf - HiveConf of name > hive.metastore.server.setugi does not exist > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.driver.hive.HiveDriver - set hive's server principal for hive > driver as hive/mysql1001.grid.ev1.inmobi....@inmobi.com > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.driver.hive.HiveDriver - Hive driver hive/platinum configured > successfully > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.server.query.QueryExecutionServiceImpl - Driver platinum for > type hive is loaded > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.server.api.query.cost.RangeBasedQueryCostTypeDecider - cost > was: HIGH(0.0), decided querytype: HIGH > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.driver.jdbc.JDBCDriver - JDBC Driver jdbc/clarity configured > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.server.query.QueryExecutionServiceImpl - Driver clarity for > type jdbc is loaded > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.server.api.query.cost.RangeBasedQueryCostTypeDecider - cost > was: HIGH(0.0), decided querytype: HIGH > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.driver.jdbc.JDBCDriver - JDBC Driver jdbc/jdbc1 configured > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.server.query.QueryExecutionServiceImpl - Driver jdbc1 for > type jdbc is loaded > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.server.api.query.cost.RangeBasedQueryCostTypeDecider - cost > was: HIGH(0.0), decided querytype: HIGH > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.driver.jdbc.JDBCDriver - JDBC Driver jdbc/prod configured > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.server.query.QueryExecutionServiceImpl - Driver prod for type > jdbc is loaded > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.server.api.query.cost.RangeBasedQueryCostTypeDecider - cost > was: HIGH(-1.0), decided querytype: LOW > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.driver.jdbc.JDBCDriver - JDBC Driver jdbc/memsql configured > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.server.query.QueryExecutionServiceImpl - Driver memsql for > type jdbc is loaded > 20 Apr 2018 05:49:56 [0d280b8d-4ee9-4879-972c-1d8a26d8b425] [main] INFO > org.apache.lens.server.query.QueryExecutionServiceImpl - Using driver > selector class: org.apache.lens.server.api.driver.MinQueryCostSelector > > > Thanks, > > Ankit Kailaswar > >
