> On May 21, 2018, 6:42 a.m., Rajitha R wrote: > > lens-server/src/main/java/org/apache/lens/server/LensServer.java > > Lines 296 (patched) > > <https://reviews.apache.org/r/67214/diff/2/?file=2026212#file2026212line299> > > > > "null should be allowed here. We should reply on Grizzly server > > creation flow to throw specific Exception or Runtim Exception instead. > > " > > This reply is unclear..if the password is not set, are we throwing an > > exception here ? since I can't see any. Am I missing something?
As discuused offline SSLContextConfigurator should handle password instead of we explicitly doing it. - Ankit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67214/#review203481 ----------------------------------------------------------- On May 21, 2018, 4:46 a.m., Ankit Kailaswar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67214/ > ----------------------------------------------------------- > > (Updated May 21, 2018, 4:46 a.m.) > > > Review request for lens. > > > Bugs: LENS-1511 > https://issues.apache.org/jira/browse/LENS-1511 > > > Repository: lens > > > Description > ------- > > enable SSL/TLS for lens server and client communication > > > Diffs > ----- > > lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java > eb12ee30 > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > ab498314 > lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java > PRE-CREATION > lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java > PRE-CREATION > lens-client/src/main/resources/lens-client-default.xml 132e1b14 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > bda995dd > lens-server/src/main/java/org/apache/lens/server/LensServer.java 7f8b3363 > lens-server/src/main/resources/lensserver-default.xml bef82518 > lens-server/src/test/resources/lens-site.xml f5a02376 > src/site/apt/admin/config.apt 8720c822 > src/site/apt/admin/hivedriver-config.apt 221c1662 > src/site/apt/user/olap-query-conf.apt 90d635b8 > > > Diff: https://reviews.apache.org/r/67214/diff/2/ > > > Testing > ------- > > build logs : > > INFO] Installing > /Users/ankit.kailaswar/inmobi/apache/lens1/lens/contrib/clients/python/pom.xml > to > /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.732 > s] > [INFO] Lens ............................................... SUCCESS [ 4.058 > s] > [INFO] Lens API ........................................... SUCCESS [ 12.199 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 11.348 > s] > [INFO] Lens Cube .......................................... SUCCESS [ 20.835 > s] > [INFO] Lens DB storage .................................... SUCCESS [ 4.510 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 6.098 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [ 8.414 > s] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 9.297 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 7.908 > s] > [INFO] Lens Server ........................................ SUCCESS [ 33.810 > s] > [INFO] Lens client ........................................ SUCCESS [ 10.876 > s] > [INFO] Lens CLI ........................................... SUCCESS [ 7.791 > s] > [INFO] Lens Examples ...................................... SUCCESS [ 4.987 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.771 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 12.208 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [ 11.166 > s] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.854 > s] > [INFO] Lens Regression .................................... SUCCESS [ 7.349 > s] > [INFO] Lens UI ............................................ SUCCESS [ 2.988 > s] > [INFO] Lens Contrib ....................................... SUCCESS [ 0.203 > s] > [INFO] Lens Contributed Clients ........................... SUCCESS [ 0.191 > s] > [INFO] Lens Python Client ................................. SUCCESS [ 0.202 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 03:02 min > [INFO] Finished at: 2018-05-18T16:49:55+05:30 > [INFO] Final Memory: 169M/1676M > [INFO] > ------------------------------------------------------------------------ > IM2086-X3:lens ankit.kailaswar$ > > > Tested with Firefox, curl, python client, lens-client. > > lens client logs, > > 18 May 2018 09:27:22 [Spring Shell] INFO > org.apache.lens.client.LensConnection - SSL is disabled, Creating http client. > 18 May 2018 09:27:53 [Spring Shell] INFO > org.apache.lens.client.LensConnection - SSL is disabled, Creating http client. > 18 May 2018 09:28:30 [Thread-2] INFO > org.apache.lens.client.LensConnectionParams - Request filter added > requestfilter > 18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnection - > SSL is disabled, Creating http client. > 18 May 2018 09:30:03 [Spring Shell] INFO > org.apache.lens.client.LensConnectionParams - Request filter added > requestfilter > 18 May 2018 09:30:03 [Spring Shell] INFO > org.apache.lens.client.LensConnectionParams - Request filter added > requestfilter > 18 May 2018 09:30:03 [Spring Shell] INFO > org.apache.lens.client.LensConnection - SSL is disabled, Creating http client. > 18 May 2018 09:30:05 [Spring Shell] INFO > org.apache.lens.client.LensConnection - SSL is disabled, Creating http client. > 18 May 2018 09:30:09 [Thread-2] INFO > org.apache.lens.client.LensConnectionParams - Request filter added > requestfilter > 18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnection - > SSL is disabled, Creating http client. > 18 May 2018 09:33:15 [Spring Shell] INFO > org.apache.lens.client.LensConnectionParams - Request filter added > requestfilter > 18 May 2018 09:33:15 [Spring Shell] INFO > org.apache.lens.client.LensConnectionParams - Request filter added > requestfilter > 18 May 2018 09:33:15 [Spring Shell] INFO > org.apache.lens.client.LensConnection - SSL is enabled, Creating https client. > 18 May 2018 09:33:17 [Spring Shell] INFO > org.apache.lens.client.LensConnection - SSL is enabled, Creating https client. > > > Thanks, > > Ankit Kailaswar > >
