----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67323/#review203877 -----------------------------------------------------------
contrib/clients/python/lens/client/log.py Lines 31 (patched) <https://reviews.apache.org/r/67323/#comment286228> Don't if and else have same implementation here? contrib/clients/python/lens/client/log.py Lines 31 (patched) <https://reviews.apache.org/r/67323/#comment286229> Don't if and else have same implementation here? contrib/clients/python/lens/client/log.py Lines 31 (patched) <https://reviews.apache.org/r/67323/#comment286230> Don't if and else have same implementation here? - Rajitha R On May 25, 2018, 1:55 p.m., Ankit Kailaswar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67323/ > ----------------------------------------------------------- > > (Updated May 25, 2018, 1:55 p.m.) > > > Review request for lens and Rajitha R. > > > Bugs: LENS-1516 > https://issues.apache.org/jira/browse/LENS-1516 > > > Repository: lens > > > Description > ------- > > In Python module we need to ignore self signed server cert for each client > request. > > > Diffs > ----- > > contrib/clients/python/lens/client/log.py e427f7fb > contrib/clients/python/lens/client/query.py b09ff19d > contrib/clients/python/lens/client/session.py 3b527e01 > > > Diff: https://reviews.apache.org/r/67323/diff/1/ > > > Testing > ------- > > https://build.corp.inmobi.com/view/Platform/job/Platform_Common_Job/2960/ > > > python client logs > /Library/Python/2.7/site-packages/urllib3/connectionpool.py:858: > InsecureRequestWarning: Unverified HTTPS request is being made. Adding > certificate verification is strongly advised. See: > https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings > InsecureRequestWarning) > /Library/Python/2.7/site-packages/urllib3/connectionpool.py:858: > InsecureRequestWarning: Unverified HTTPS request is being made. Adding > certificate verification is strongly advised. See: > https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings > InsecureRequestWarning) > /Library/Python/2.7/site-packages/urllib3/connectionpool.py:858: > InsecureRequestWarning: Unverified HTTPS request is being made. Adding > certificate verification is strongly advised. See: > https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings > InsecureRequestWarning) > /Library/Python/2.7/site-packages/urllib3/connectionpool.py:858: > InsecureRequestWarning: Unverified HTTPS request is being made. Adding > certificate verification is strongly advised. See: > https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings > InsecureRequestWarning) > <lens.client.session.LensSessionClient object at 0x1079b7b10> > > > Thanks, > > Ankit Kailaswar > >
