----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67523/#review204544 -----------------------------------------------------------
Ship it! Ship It! - Puneet Gupta On June 11, 2018, 3:43 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67523/ > ----------------------------------------------------------- > > (Updated June 11, 2018, 3:43 p.m.) > > > Review request for lens and Puneet Gupta. > > > Bugs: LENS-1519 > https://issues.apache.org/jira/browse/LENS-1519 > > > Repository: lens > > > Description > ------- > > The current Lens set up uses a hardcoded lens result download url. This can > be made configurable to allow clients set their own download urls if needed. > If this configuration is set, the url should internally handle how to > download the result from lens. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 5a4e3dd > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DefaultDownloadResultUrlProvider.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DownloadResultUrlProvider.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java > 3f24343 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 4d141e5 > src/site/apt/user/cli.apt 12bc88c > src/site/apt/user/client-config.apt 4f0b2b4 > > > Diff: https://reviews.apache.org/r/67523/diff/6/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
