----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68520/#review208339 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java Lines 98 (patched) <https://reviews.apache.org/r/68520/#comment292195> Can these be derived from existing non-time partition columns instead of new property being added? - Amareshwari Sriramadasu On Sept. 5, 2018, 2:55 a.m., Rajashekhar Choukimath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68520/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2018, 2:55 a.m.) > > > Review request for lens, Amareshwari Sriramadasu, Ankit Kailaswar, and > Rajitha R. > > > Bugs: LENS-1533 > https://issues.apache.org/jira/browse/LENS-1533 > > > Repository: lens > > > Description > ------- > > LENS-1533: Adding support for Partition Columns to queried without giving > additional xml tag valid.columns > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 8f3f4aa > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > e6afcff > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > 96948cc > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > e351d7f > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > 7dfb166 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 44411f2 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 193ce6b > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 6f054c4 > > > Diff: https://reviews.apache.org/r/68520/diff/1/ > > > Testing > ------- > > Done on Local Test VM. > > > Thanks, > > Rajashekhar Choukimath > >
