> On Sept. 10, 2018, 3:23 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > > Lines 38 (patched) > > <https://reviews.apache.org/r/68670/diff/1/?file=2086613#file2086613line38> > > > > Can the conf be named with prefix similar to other configs?
Also, document the config in lens-server-default.xml and update .apt files. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68670/#review208471 ----------------------------------------------------------- On Sept. 7, 2018, 4:57 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68670/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2018, 4:57 p.m.) > > > Review request for lens, Amareshwari Sriramadasu and Ankit Kailaswar. > > > Bugs: LENS-1534 > https://issues.apache.org/jira/browse/LENS-1534 > > > Repository: lens > > > Description > ------- > > The current authorizer instantiation is separated in cubemetastore and > queryrewrite. There is a need to merge this by creating only a single > instance of authorizer for resource optimization. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/authorization/AuthorizationUtil.java > 5ae2cfd > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b1c1ae4 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 5bdfea4 > > lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAuthorizationResolver.java > f1376ca > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 9499f0c > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryAuthorizationResolver.java > 13b345f > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > efaf5d2 > > lens-server-api/src/main/java/org/apache/lens/server/api/authorization/LensAuthorizer.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/LensServer.java 701ebbe > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > 7cccf30 > > > Diff: https://reviews.apache.org/r/68670/diff/1/ > > > Testing > ------- > > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.399s] > [INFO] Lens .............................................. SUCCESS [2.545s] > [INFO] Lens API .......................................... SUCCESS [17.979s] > [INFO] Lens API for server and extensions ................ SUCCESS [15.777s] > [INFO] Lens Cube ......................................... SUCCESS [3:15.811s] > [INFO] Lens DB storage ................................... SUCCESS [12.376s] > [INFO] Lens Query Library ................................ SUCCESS [9.909s] > [INFO] Lens Hive Driver .................................. SUCCESS [1:04.683s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [39.626s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.802s] > [INFO] Lens Server ....................................... SUCCESS > [10:15.769s] > [INFO] Lens client ....................................... SUCCESS [1:19.107s] > [INFO] Lens CLI .......................................... SUCCESS [1:09.361s] > [INFO] Lens Examples ..................................... SUCCESS [5.984s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.616s] > [INFO] Lens Distribution ................................. SUCCESS [10.112s] > [INFO] Lens ML Lib ....................................... SUCCESS [57.461s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.303s] > [INFO] Lens Regression ................................... SUCCESS [9.392s] > [INFO] Lens UI ........................................... SUCCESS [24.584s] > [INFO] Lens Contrib ...................................... SUCCESS [0.255s] > [INFO] Lens Contributed Clients .......................... SUCCESS [0.234s] > [INFO] Lens Python Client ................................ SUCCESS [0.235s] > [INFO] --------------------------------------------------------------------- > > > Thanks, > > Rajitha R > >
