RajashekharChoukimath opened a new pull request #34: Fixed Issues in Lens for Azure Migrations URL: https://github.com/apache/lens/pull/34 Fixed following Issues in Lens for Azure Migrations 1) Bug in Lens-Metastore for single fact granularity -- https://jira.corp.inmobi.com:8443/browse/RNA-13729. Explaination: This had a special case for handling facts with one-update-period and multiple-update-periods. The case which handled one-update-period had a bug while generating the name of the hive table whole format is update_period-fact_name, the update_period was coming as null. 2) In the Azure migration lens is only used as query-builder and not used for query execution. Prepared Query in JDBC Driver was invoking the underlying JDBC Driver, I have removed that part. 3) We are using lens for getting the rewritten driver query, so the prepared query has to be inserted into the database. File level explainations: 1) CubeMetastoreClient.java -- This had a special case for handling facts with one-update-period and multiple-update-periods. The case which handled one-update-period had a bug while generating the name of the hive table whole format is update_period-fact_name, the update_period was coming as null. 2) ESDriver.java -- related to item 4. 3) TestHiveDriver.java -- related to item 4. 4) JDBCDriver.java -- This was trying to invoke the underlying JDBC Driver while preparing the query, which is not needed, I have the removed the all the code parts a) which triggered the underlying database b) maintained a copy of PreparedStatement and storing it in Map, so as to return it directly from the Map. c) also making sure we close when we are shutting down the Lens, we are closing the instances of PreparedStatement in the Map gracefully. 5) TestJDBCDriver.java -- related to item 4. 6) LensDriver.java -- related to item 4. 7) PreparedQueryContext.java -- We want to store the prepared query into the DB similar to finished_queries, so added start and end times. Also used these fields to measure the time lens takes to prepare the query. Related to item 9 8) MockDriver.java -- related to item 4. 9) LensServerDAO.java -- We want to store the prepared query into the DB similar to finished_queries, so we created a new table called prepared_queries and added the cube and driver query into it. 10)QueryExecutionServiceImpl.java -- Related to item 9.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
