RajashekharChoukimath commented on a change in pull request #34: [LENS-1545]:
Fixed a Bug and made changes for PreparedQuery.
URL: https://github.com/apache/lens/pull/34#discussion_r302960364
##########
File path:
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java
##########
@@ -821,4 +823,32 @@ public boolean deleteActiveSession(LensSessionHandle
sessionId) throws LensExcep
return result;
}
+
+ /**
+ * DAO method to insert a new Prepared query into Table.
+ *
+ * @param preparedQueryContext to be inserted
+ * @throws SQLException the exception
+ */
+ public void insertPreparedQuery(PreparedQueryContext preparedQueryContext)
throws SQLException {
Review comment:
This is a void method, and anyways it calls external system to insert data,
I don't think we should be unit-testing here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
