[
https://issues.apache.org/jira/browse/LENS-1545?focusedWorklogId=294665&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294665
]
ASF GitHub Bot logged work on LENS-1545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/19 10:15
Start Date: 14/Aug/19 10:15
Worklog Time Spent: 10m
Work Description: RajashekharChoukimath commented on pull request #35:
[LENS-1545]: Fixed Bug in Prepared Query.
URL: https://github.com/apache/lens/pull/35#discussion_r313801600
##########
File path:
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
##########
@@ -556,6 +556,8 @@ public String getPlan() {
public QueryCost estimate(AbstractQueryContext qctx) throws LensException {
MethodMetricsContext validateGauge =
MethodMetricsFactory.createMethodGauge(qctx.getDriverConf(this), true,
VALIDATE_GAUGE);
+ String rewrittenQuery = rewriteQuery(qctx);
Review comment:
In the azure-world, we are not going to have Lens interacting with the
actual underlying drivers.
https://docs.google.com/document/d/1K5Q3ZQZAEGkf472DZ_zuLbHZ9ycx86YAEhqbxO0o-aA/edit#
The cleaner way for me is to remove driverconnection which Lens is making
for the explain part in prepareInternal Method
https://github.com/apache/lens/blob/master/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java#L728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 294665)
Time Spent: 3h 20m (was: 3h 10m)
> Fixed a Bug and made changes for PreparedQuery
> ----------------------------------------------
>
> Key: LENS-1545
> URL: https://issues.apache.org/jira/browse/LENS-1545
> Project: Apache Lens
> Issue Type: Improvement
> Components: api, cube, server
> Reporter: Rajashekhar
> Assignee: Amareshwari Sriramadasu
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Fixed following Issues in Lens for Azure Migrations
> # Bug in Lens-Metastore for single fact granularity --
> https://issues.apache.org/jira/browse/LENS-1544. Explaination: This had a
> special case for handling facts with one-update-period and
> multiple-update-periods. The case which handled one-update-period had a bug
> while generating the name of the hive table whole format is
> update_period-fact_name, the update_period was coming as null.
> # JDBCDriver.java was invoking JDBC Driver while validating the prepared
> query, I don't need this functionality so blocking this via already existing
> config parameter JDBC_VALIDATE_THROUGH_PREPARE.
> 2a) Old Flow:
> {code}
> esitmate()
> --- | --> validate
> -----| --> JDBC_VALIDATE_THROUGH_PREPARE condition to prepare through if
> condition
> -----|--> prepareInternal()
> ----------------|--> rewrite -- Rewritting take place
> {code}
> 2b) New Flow:
> {code}
> esitmate()
> ---| --> rewrite -- Rewritting take place
> ---| --> validate
> -----| --> JDBC_VALIDATE_THROUGH_PREPARE condition to prepare through if
> condition
> -----|--> prepareInternal()
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
