[
https://issues.apache.org/jira/browse/LENS-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222930#comment-14222930
]
Rajat Khandelwal commented on LENS-14:
--------------------------------------
Need not add new test cases. Since In the patch there are two kinds of changes:
* Changes in LOGIC
* Changes in corresponding test cases.
The changes in cube test setup are the following:
I've added a cheapFact in testcube which has only one storage called c99. c99
is not supported in any of the test cases. So if lightest fact resolution
happens before storage table name resolution, it would pick just cheapFact and
it would get ignored at the storage table resolution step since c99 is
unsupported. On the other hand, if storage table name resolution happens first,
cheapFact would get rejected then and there and then lightest fact resolver
would find lightest among only those facts have supported storages.
Changes in testcases ensure that the testcase would fail if we leave the logic
untouched.
> Lightest fact first config wont work with more than one storage
> ---------------------------------------------------------------
>
> Key: LENS-14
> URL: https://issues.apache.org/jira/browse/LENS-14
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
> Affects Versions: 2.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Rajat Khandelwal
> Fix For: 2.0
>
> Attachments: LENS-14.0.patch, LENS-14.1.patch, LENS-14.2.patch
>
>
> With lightest fact resolver first config enabled, it would pick only one
> lightest fact to be lightest. And storage table resolver might skip it if
> current driver cannot work on the storage chosen.
> The problem is StorageTableResolver resolves supported storages, final
> storage tables and also checks for partitions available in tables. The
> solution is to split StorageTableResolver into two resolvers sothat we first
> apply storage table resolver to find supported storages and storage tables.
> If lightest fact first config enabled, then apply LightestFactResolver and
> then apply storage partition resolver, which checks for partition existence
> on the fact storage tables.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
