[
https://issues.apache.org/jira/browse/LENS-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228632#comment-14228632
]
Amareshwari Sriramadasu commented on LENS-20:
---------------------------------------------
Some comments on the work in progress patch attached :
* Remove final qualifier from conf xml files. Because final has to be specified
on the overriden site.xml files and not in default.xml files.
* There are too many changes wrt replacing ctx.getSelectedDriver() with
ctx.getDriverContext().getSelectedDriver(), i would say add the method
getSelectedDriver in context class, which returns
getDriverContext().getSelectedDriver().
Same wrt ctx.getDriverQuery() to
ctx.getDriverContext().getSelectedDriverQuery() changes.
* Seems QueryContext serialization across restarts is not taken care with the
patch. Selected driver query needs to be persisted across restarts.
> Driver Specific Configuration should be set in Query Context
> ------------------------------------------------------------
>
> Key: LENS-20
> URL: https://issues.apache.org/jira/browse/LENS-20
> Project: Apache Lens
> Issue Type: Improvement
> Components: api
> Affects Versions: 2.0
> Reporter: Suma Shivaprasad
> Assignee: Amareshwari Sriramadasu
> Fix For: 2.0
>
> Attachments: LENS-20.progress.patch
>
>
> Driver specific query conf is being merged currently at multiple places in
> code. Consolidating this in DriverSelectorQueryContext
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
