> On Nov. 29, 2014, 3:59 a.m., Suma Shivaprasad wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java, line > > 425 > > <https://reviews.apache.org/r/28516/diff/3/?file=778251#file778251line425> > > > > pls use an iterator for removing > > Amareshwari Sriramadasu wrote: > All the pruning code in JoinResolver is using this style. Not planning to > change as part of the change, as it might introduce some more bugs. > > Suma Shivaprasad wrote: > I feel it is better to take care of it since it could result in > unexpected behaviour a stated here - > http://stackoverflow.com/questions/223918/iterating-through-a-list-avoiding-concurrentmodificationexception-when-removing
Sure. Will do it as part of separate jira. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28516/#review63278 ----------------------------------------------------------- On Nov. 28, 2014, 5:36 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28516/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2014, 5:36 p.m.) > > > Review request for lens, Rajat Khandelwal and Suma Shivaprasad. > > > Bugs: LENS-59 > https://issues.apache.org/jira/browse/LENS-59 > > > Repository: lens > > > Description > ------- > > This is to allow join chains to be specified for cube. Here is the approach: > Cube will have set of JoinChain associated > JoinChain will have name, displayString and description; And the more than > one chain can associated with name. > Chain is nothing but List of TableReference ( in the order of links) > Reference dim attribute right nowcan refer to table.column; This will be > extended to include chainName.column. This would allow giving more > information about the reference attribute like display string, description > and etc. > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 000d27e > lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java d7041ad > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeInterface.java > 62a5d31 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 1fddd71 > lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java > f511cfe > lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > ddc87dc > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > bcdfddb > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java > afb4a22 > lens-cube/src/main/java/org/apache/lens/cube/metadata/TableReference.java > 995e9cb > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 7128854 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > d52f9a9 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 09dd5b9 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > a985eda > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 3ae11db > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 56958b6 > > Diff: https://reviews.apache.org/r/28516/diff/ > > > Testing > ------- > > > Thanks, > > Amareshwari Sriramadasu > >
