----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28596/#review63504 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java <https://reviews.apache.org/r/28596/#comment105775> Should we make Path a logical entity. Path would extend from List<TableReference> and have additional methods like sourceColumn, destTable, destColumn etc. Would make this class a lot more readable. lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java <https://reviews.apache.org/r/28596/#comment105776> rename to getIntermediateDimensions ? lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java <https://reviews.apache.org/r/28596/#comment105777> I hope this is properly tested. Changes look okay but better to be sure. lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java <https://reviews.apache.org/r/28596/#comment105779> Won't we have discarded all facts if no fact contains a particular join chain's src column? lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java <https://reviews.apache.org/r/28596/#comment105774> `{` should be on the same line. - Rajat Khandelwal On Dec. 2, 2014, 7:25 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28596/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2014, 7:25 a.m.) > > > Review request for lens and Jaideep dhok. > > > Bugs: LENS-41 > https://issues.apache.org/jira/browse/LENS-41 > > > Repository: lens > > > Description > ------- > > Includes changes required for query rewriter to understand chainName.column > and resolve the join corresponding to chain. > > Still pending: If query involves two different chains leading same > destination tables. Will raise a followup issue and put patch there. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java > ebdf952 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java > 51a9528 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > d255566 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 8b9e604 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 2409db8 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 93bcabe > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > bc15890 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 485ff46 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > 114bbc4 > > Diff: https://reviews.apache.org/r/28596/diff/ > > > Testing > ------- > > > Thanks, > > Amareshwari Sriramadasu > >
