----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28689/#review63839 -----------------------------------------------------------
Ship it! Ship It! - Jaideep dhok On Dec. 4, 2014, 6:17 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28689/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 6:17 a.m.) > > > Review request for lens and Jaideep dhok. > > > Bugs: LENS-89 > https://issues.apache.org/jira/browse/LENS-89 > > > Repository: lens > > > Description > ------- > > LENS-89 Fixes NPE in CandidateTableResolver. > Added regression test which fails without the fix. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 482ef78 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 03cb341 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 5ee336f > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 0278ab4 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > ee6f00f > > Diff: https://reviews.apache.org/r/28689/diff/ > > > Testing > ------- > > All tests pass : > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [4.958s] > [INFO] Lens .............................................. SUCCESS [15.128s] > [INFO] Lens API .......................................... SUCCESS [13.474s] > [INFO] Lens API for server and extensions ................ SUCCESS [10.105s] > [INFO] Lens Cube ......................................... SUCCESS [8:34.637s] > [INFO] Lens DB storage ................................... SUCCESS [24.128s] > [INFO] Lens Query Library ................................ SUCCESS [10.107s] > [INFO] Lens Hive Driver .................................. SUCCESS [4:17.168s] > [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [6.879s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [35.931s] > [INFO] Lens Server ....................................... SUCCESS > [19:45.907s] > [INFO] Lens client ....................................... SUCCESS [18.942s] > [INFO] Lens CLI .......................................... SUCCESS [5:06.490s] > [INFO] Lens Examples ..................................... SUCCESS [4.841s] > [INFO] Lens Distribution ................................. SUCCESS [18.907s] > [INFO] Lens Client Distribution .......................... SUCCESS [24.130s] > [INFO] Lens ML Lib ....................................... SUCCESS [3:05.846s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
