-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28555/#review63684
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java
<https://reviews.apache.org/r/28555/#comment105954>

    We need to do this only if REPLACE_TIMEDIM_WITH_PART_COL is true



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java
<https://reviews.apache.org/r/28555/#comment105955>

    Shouldnt the value for filter be in quotes?



lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
<https://reviews.apache.org/r/28555/#comment105956>

    Not latest conditions should be added for all pt, it, et. No?


- Amareshwari Sriramadasu


On Dec. 3, 2014, 6:02 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28555/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 6:02 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-33
>     https://issues.apache.org/jira/browse/LENS-33
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-33: Latest partitions from fact tables should be skipped on the final 
> query
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
> ad6d3fbe4a099f50cb82034785851d9db1937350 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 2409db842053b4c99511f960a96427f0176e259b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
> 0070ec2624252f2684bb55610b286646b2e968a5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 
> 88a1b7dce9c89eb8d7395a311b25fd2bf1da6026 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 
> a7819c1a7410041b55f77564502df00f46ed5b21 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
> 8b4756fdc32bb488b72310fda7d3c0bd18b9458c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 
> 01cfcf70fb1fa39c456519189269d1f2e2311d08 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 485ff461283c93c6e7382cb1d14e1b77e38c6530 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> 17ae4c08b93cdd2d41958f986685c424fd14caf7 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
>  ee6f00f3f20c127b0c557eac114c756f69ffa638 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
> 114bbc4a821cc05749f02eab7e1ae480bbf9fb89 
> 
> Diff: https://reviews.apache.org/r/28555/diff/
> 
> 
> Testing
> -------
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [37.262s]
> [INFO] Lens .............................................. SUCCESS [5:52.058s]
> [INFO] Lens API .......................................... SUCCESS [1:13.315s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.899s]
> [INFO] Lens Cube ......................................... SUCCESS [7:19.968s]
> [INFO] Lens DB storage ................................... SUCCESS [15.891s]
> [INFO] Lens Query Library ................................ SUCCESS [7.291s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:41.192s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [5.694s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [31.473s]
> [INFO] Lens Server ....................................... SUCCESS 
> [15:37.532s]
> [INFO] Lens client ....................................... SUCCESS [22.020s]
> [INFO] Lens CLI .......................................... SUCCESS [4:19.125s]
> [INFO] Lens Examples ..................................... SUCCESS [1.896s]
> [INFO] Lens Distribution ................................. SUCCESS [14.368s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.319s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:43.040s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 42:37.651s
> [INFO] Finished at: Tue Dec 02 23:58:59 IST 2014
> [INFO] Final Memory: 120M/625M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Reply via email to