----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28798/#review64344 -----------------------------------------------------------
Can you update review request without LENS-33 changes? - Amareshwari Sriramadasu On Dec. 8, 2014, 6:51 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28798/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 6:51 a.m.) > > > Review request for lens. > > > Bugs: LENS-94 > https://issues.apache.org/jira/browse/LENS-94 > > > Repository: lens > > > Description > ------- > > Fix for the issue. Patches for LENS-89 and LENS-33 have been applied since > they had already gotten "Ship It" and the files to be changed were common. > > It's WIP right now. Two test cases failing and there are a log of LOG.info > added for debugging. Will remove them after initial review. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > ad6d3fb > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 482ef78 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 03cb341 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > 1325c05 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 0070ec2 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 88a1b7d > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > f604d0c > lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java > a7819c1 > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > c2fef7e > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 5ee336f > lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java > f067d0a > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java > 8b4756f > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 3fb9d09 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 01cfcf7 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java > 4299874 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 0278ab4 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 17ae4c0 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > ee6f00f > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java > 173c458 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > 76907ea > > Diff: https://reviews.apache.org/r/28798/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
