-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28848/
-----------------------------------------------------------

Review request for lens and Amareshwari Sriramadasu.


Bugs: LENS-101
    https://issues.apache.org/jira/browse/LENS-101


Repository: lens


Description
-------

For snowflake joins between dimensions the left join key has to be removed form 
the fact sub-query. It should have columns those can be queried from fact. 


Diffs
-----

  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 f160f3f 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
 40f3d91 

Diff: https://reviews.apache.org/r/28848/diff/


Testing
-------

In rewriter the keys suffixed with fact alias are considered for fact subquery 
building. Added unit test for the same.


Thanks,

Sushil Mohanty

Reply via email to