-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28937/
-----------------------------------------------------------

Review request for lens, Rajat Khandelwal and Suma Shivaprasad.


Bugs: LENS-95
    https://issues.apache.org/jira/browse/LENS-95


Repository: lens


Description
-------

Timerange resolver has issues with current join chain query rewriting, as the 
AST has been modified in AliasReplacer.

The fix removes code changes from AliasReplacer and fixes 
DenormalizationResolver to figure out chained ref columns.

Added testcases with time dimension defined through join chain.

This would fix LENS-95 also, but will LENS-95 open for adding more testcases


Diffs
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java d493e07 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
9136f8e 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 
b9f1328 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java e8cad1d 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 99d1ca7 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
 2661380 

Diff: https://reviews.apache.org/r/28937/diff/


Testing
-------

TestJoinResolver and TestTimeRangeWriterWithQuery pass with changes.

Will run all tests and update


Thanks,

Amareshwari Sriramadasu

Reply via email to