> On Dec. 15, 2014, 8:34 a.m., Jaideep dhok wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java, > > line 28 > > <https://reviews.apache.org/r/29036/diff/1/?file=791656#file791656line28> > > > > Since service lookup is by name, it would be useful to move > > HiveSessionService.NAME to the interface.
Will do. I saw that Metastore service did not have a name in the service definition. But now I do see that the other names are in the service defintion. And it makes sense - Jothi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29036/#review65075 ----------------------------------------------------------- On Dec. 15, 2014, 8:28 a.m., Jothi Padmanabhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29036/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2014, 8:28 a.m.) > > > Review request for lens. > > > Bugs: lens-104 > https://issues.apache.org/jira/browse/lens-104 > > > Repository: lens > > > Description > ------- > > Lens-104. Add session service to server-api > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > f45fe3c > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > 4d4bb53 > lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java > 29dc669 > > Diff: https://reviews.apache.org/r/29036/diff/ > > > Testing > ------- > > Changes are in interface, no new tests added. Also, did not change the > TestSessionUI and TestServerRestart as they seem to be testing the internals > of the HiveSessionService implementation > > > Thanks, > > Jothi Padmanabhan > >
