----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29048/#review65185 -----------------------------------------------------------
I see a lot of trailing whitespace. Would be great if you could remove them. +1 otherwise. lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java <https://reviews.apache.org/r/29048/#comment108214> - Rajat Khandelwal On Dec. 15, 2014, 11:19 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29048/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2014, 11:19 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-82 > https://issues.apache.org/jira/browse/LENS-82 > > > Repository: lens > > > Description > ------- > > MockDriver and MockQueryContext classes are present in lens-server-api. They > should be moved to test and other modules can depend on lens-server-api's > test jar module. > > > Diffs > ----- > > lens-cli/pom.xml 03b12ab > lens-cube/pom.xml 2a461d1 > lens-driver-hive/pom.xml f030251 > lens-ml-lib/pom.xml f9e7e0f > lens-query-lib/pom.xml 10b826a > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockDriver.java > 341824e > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockFailDriver.java > 7ed2fd0 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockQueryContext.java > 749ef60 > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java > PRE-CREATION > lens-server/pom.xml 9a8fb7d > > Diff: https://reviews.apache.org/r/29048/diff/ > > > Testing > ------- > > [INFO] Building jar: > /Users/raju.bairishetti/Desktop/git/apache-open-source-porjects/incubator-lens/lens-ml-lib/target/lens-ml-lib-2.0.0-SNAPSHOT-tests.jar > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 7.769 > s] > [INFO] Lens ............................................... SUCCESS [ 15.605 > s] > [INFO] Lens API ........................................... SUCCESS [ 13.842 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 13.428 > s] > [INFO] Lens Cube .......................................... SUCCESS [09:54 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 24.317 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 8.198 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [03:29 > min] > [INFO] Lens Driver for Cloudera Impala .................... SUCCESS [ 7.357 > s] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 32.663 > s] > [INFO] Lens Server ........................................ SUCCESS [09:01 > min] > [INFO] Lens client ........................................ SUCCESS [ 13.637 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:58 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 1.679 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 13.498 > s] > [INFO] Lens Client Distribution ........................... SUCCESS [ 13.139 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:34 > min] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 29:43 min > [INFO] Finished at: 2014-12-15T16:44:10+05:30 > [INFO] Final Memory: 79M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Raju Bairishetti > >
