> On Dec. 11, 2014, 11:58 p.m., Amareshwari Sriramadasu wrote: > > Jaideep, If you are planning to add testing of cancel functionality, can > > you update the patch? If not, Can you create a jira for the same. You can > > create two jiras for one for HiveDriver and one for JDBCDriver. > > > > The patch is good enough to solve the inetrmittent failures to avoid build > > failures. > > Jaideep dhok wrote: > Current test already verifies cancel funcitonality which is why test > fails intermittently. Otherwise it would have failed all the time.
Agreed. But with the changes we are merging there are cases when cancel wont be tested, but tests will pass (instead of failing, as it is doing now). We can create a jira open to fix that functionality - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28630/#review64817 ----------------------------------------------------------- On Dec. 3, 2014, 5:10 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28630/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 5:10 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Sushil Mohanty. > > > Bugs: LENS-87 > https://issues.apache.org/jira/browse/LENS-87 > > > Repository: lens > > > Description > ------- > > Test case should check if query cancel was successful and then evaluate > status accordingly. > > > Diffs > ----- > > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 30b7935 > > Diff: https://reviews.apache.org/r/28630/diff/ > > > Testing > ------- > > Modified exsiting test for cancel query. > > > Thanks, > > Jaideep dhok > >
