> On Dec. 18, 2014, 4:45 a.m., Amareshwari Sriramadasu wrote: > > Changes look fine except the ASTNode casting in many places. > > Sushil Mohanty wrote: > I did the IDE setting to remove all traling white spaces. It > automatically removed the unnecessary casting of ASTNode and added "final" > keyword in few StringBuilder instance variables.
No issues. I thought casting was added now. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29085/#review65451 ----------------------------------------------------------- On Dec. 16, 2014, 6:08 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29085/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2014, 6:08 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-126 > https://issues.apache.org/jira/browse/LENS-126 > > > Repository: lens > > > Description > ------- > > Such queries fail due to alias is missing in the referred column in order by. > replaceAlias expects column to be prefixed with "alias." for eg. > alias.column. To handle such cases where alias is not specified. we need to > replace the column as it is in the tree. > > > Diffs > ----- > > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > 8015481 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > 15cb692 > > Diff: https://reviews.apache.org/r/29085/diff/ > > > Testing > ------- > > Tested alias replacement in the tree and added unit test. > > > Thanks, > > Sushil Mohanty > >
