----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29353/#review65868 -----------------------------------------------------------
Ship it! Ship It! - Amareshwari Sriramadasu On Dec. 23, 2014, 5:17 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29353/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 5:17 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-144 > https://issues.apache.org/jira/browse/LENS-144 > > > Repository: lens > > > Description > ------- > > Currently, Lens server emits stats to console or ganglia based on the > provided configuration. But currently lens server is not emitting stats to > ganglia because it is not reading the configuration. > code snippet > if (hiveConf.getBoolean(LensConfConstants.ENABLE_CONSOLE_METRICS, false)) { > // ganglia reporter initialization > ... > } > instead it should be > Fix > if (hiveConf.getBoolean(LensConfConstants.ENABLE_GANGLIA_METRICS, false)) { > // ganglia reporter initialization > ... > } > > > Diffs > ----- > > lens-server/src/main/java/org/apache/lens/server/MetricsServiceImpl.java > b0774e0 > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > 19a1a69 > > Diff: https://reviews.apache.org/r/29353/diff/ > > > Testing > ------- > > Updated the existing test class LensJerseyTest > > > Thanks, > > Raju Bairishetti > >
