> On Dec. 23, 2014, 7 a.m., Amareshwari Sriramadasu wrote: > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java, > > line 756 > > <https://reviews.apache.org/r/29305/diff/2/?file=799282#file799282line756> > > > > We are not pushing dim2 id lookups into subquery. Is that ok?
Yes its okay. - Sushil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29305/#review65873 ----------------------------------------------------------- On Dec. 23, 2014, 6:14 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29305/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 6:14 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-141 > https://issues.apache.org/jira/browse/LENS-141 > > > Repository: lens > > > Description > ------- > > Currently join conditions are getting added as filters in fact subquery. > Fixed by excluding them from fact subquery and fact filter push down. > > > Diffs > ----- > > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > b05d87f > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > 6ca0d2d > > Diff: https://reviews.apache.org/r/29305/diff/ > > > Testing > ------- > > Tested the fix and added unit test. All tests are passing. > > > Thanks, > > Sushil Mohanty > >
