----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29354/#review65884 -----------------------------------------------------------
Other changes look fine. tools/conf-pseudo-distr/client/lens-client-site.xml <https://reviews.apache.org/r/29354/#comment109157> All these variables shouldnt be required now, as default params in server and session configs are already getting set. We need to remove them from tools/conf/client/lens-client-site.xml also. - Amareshwari Sriramadasu On Dec. 23, 2014, 8:01 a.m., sharad agarwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29354/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 8:01 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Lens-146 seperated client and server conf for docker > > > Diffs > ----- > > lens-client-dist/src/main/assembly/client-dist.xml 56c4367 > lens-dist/src/main/assembly/server-dist.xml 8977733 > lens-docker/lens-test/Dockerfile 42d53bd > lens-docker/lens-test/conf/hivedriver-site.xml f179ecd > lens-docker/lens-test/conf/jdbcdriver-site.xml 235187a > lens-docker/lens-test/conf/lens-env.sh 6a6222c > lens-docker/lens-test/conf/lens-site.xml 8110ab8 > lens-docker/lens-test/conf/log4j.properties afadc2f > lens-docker/lens-test/lens-bootstrap.sh 37e725d > tools/conf-pseudo-distr/client/lens-client-site.xml PRE-CREATION > tools/conf-pseudo-distr/client/log4j.properties PRE-CREATION > tools/conf-pseudo-distr/lens-env.sh PRE-CREATION > tools/conf-pseudo-distr/server/hivedriver-site.xml PRE-CREATION > tools/conf-pseudo-distr/server/jdbcdriver-site.xml PRE-CREATION > tools/conf-pseudo-distr/server/lens-site.xml PRE-CREATION > tools/conf-pseudo-distr/server/log4j.properties PRE-CREATION > > Diff: https://reviews.apache.org/r/29354/diff/ > > > Testing > ------- > > build and started the docker, no exception comes. > > > Thanks, > > sharad agarwal > >
