-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29361/
-----------------------------------------------------------
(Updated Dec. 23, 2014, 10:22 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-143
https://issues.apache.org/jira/browse/LENS-143
Repository: lens
Description
-------
Adding few null and empty checks while iterating over columns
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java b2059a9
lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java
5b00ff3
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
02ce7a9
Diff: https://reviews.apache.org/r/29361/diff/
Testing
-------
Added new unit test to verify dimension attribute query with cube through join.
No impact on existing tests -
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.228s]
[INFO] Lens .............................................. SUCCESS [4.528s]
[INFO] Lens API .......................................... SUCCESS [14.449s]
[INFO] Lens API for server and extensions ................ SUCCESS [8.022s]
[INFO] Lens Cube ......................................... SUCCESS [7:27.509s]
[INFO] Lens DB storage ................................... SUCCESS [17.265s]
[INFO] Lens Query Library ................................ SUCCESS [6.720s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:26.074s]
[INFO] Lens Driver for Cloudera Impala ................... SUCCESS [5.248s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [32.755s]
[INFO] Lens Server ....................................... SUCCESS [17:30.682s]
[INFO] Lens client ....................................... SUCCESS [44.111s]
[INFO] Lens CLI .......................................... SUCCESS [3:43.395s]
[INFO] Lens Examples ..................................... SUCCESS [0.882s]
[INFO] Lens Distribution ................................. SUCCESS [0.272s]
[INFO] Lens Client Distribution .......................... SUCCESS [0.611s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:32.640s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 35:58.602s
[INFO] Finished at: Tue Dec 23 15:45:48 IST 2014
[INFO] Final Memory: 118M/822M
[INFO] ------------------------------------------------------------------------
Thanks,
Jaideep dhok
