----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29344/#review65915 -----------------------------------------------------------
Ship it! Ship It! - Jaideep dhok On Dec. 23, 2014, 12:50 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29344/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 12:50 a.m.) > > > Review request for lens and Jaideep dhok. > > > Bugs: LENS-145 > https://issues.apache.org/jira/browse/LENS-145 > > > Repository: lens > > > Description > ------- > > Fixes creation of jdbc result formatter when persist in driver conf is true > > > Diffs > ----- > > lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java > 116335f > > lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java > 64a410a > > Diff: https://reviews.apache.org/r/29344/diff/ > > > Testing > ------- > > Updated TestResultFormatting to test for formatter instance for existing > cases. > > Test jdbc formmating through examples, as we dont have integration tests with > jdbc driver yet. > > lens-shell>set lens.query.enable.persistent.resultset=true > Set param succeeded > lens-shell>set lens.query.enable.persistent.resultset.indriver=true > Set param succeeded > lens-shell>query execute cube select id,name from sample_db_dim > ID NAME > Results of query stored at : > file:/tmp/lensreports/c0f59e29-8637-48c0-8244-bba9f1905bf1.csv 0 rows process > in (8) seconds. > > lens-shell>close > > $ cat /tmp/lensreports/c0f59e29-8637-48c0-8244-bba9f1905bf1.csv > "1","first" > "2","second" > "3","third" > > > Thanks, > > Amareshwari Sriramadasu > >
