----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29391/#review66017 -----------------------------------------------------------
Can you take care of trimming trialing white spaces? lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java <https://reviews.apache.org/r/29391/#comment109364> This port would conflict with default port, if a lens server is already running on the machine. lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java <https://reviews.apache.org/r/29391/#comment109366> Same again. Conflicts with default port, can we use a different port? tools/scripts/lens-run-class.sh <https://reviews.apache.org/r/29391/#comment109365> Are hadoop jars required for this utility runner? - Amareshwari Sriramadasu On Dec. 24, 2014, 6:54 a.m., sharad agarwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29391/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2014, 6:54 a.m.) > > > Review request for lens, Jaideep dhok and Suma Shivaprasad. > > > Repository: lens > > > Description > ------- > > Lens-153 Add example execution runner > > > Diffs > ----- > > lens-client-dist/src/main/assembly/client-dist.xml 8190720 > lens-docker/lens-test/Dockerfile f35c0ff > lens-docker/lens-test/lens-bootstrap.sh 23ed307 > lens-ml-dist/LICENSE.txt PRE-CREATION > lens-ml-dist/pom.xml PRE-CREATION > lens-ml-dist/src/main/assembly/ml-dist.xml PRE-CREATION > lens-ml-dist/src/site/apt/index.apt PRE-CREATION > lens-ml-lib/data/naive_bayes/ml.properties PRE-CREATION > lens-ml-lib/data/naive_bayes/naive_bayes_train.data dfb9ccd > lens-ml-lib/data/naive_bayes/test.data PRE-CREATION > lens-ml-lib/data/naive_bayes/train.data PRE-CREATION > lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 5c5bc65 > lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java PRE-CREATION > lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java d2bed0a > lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java d1318fc > lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java PRE-CREATION > lens-ml-lib/tools/scripts/lens-ml-classpath.sh PRE-CREATION > pom.xml 9265a77 > tools/conf-pseudo-distr/client/lens-client-site.xml 706e356 > tools/conf-pseudo-distr/server/lens-site.xml 8110ab8 > tools/scripts/lens-config.sh 8bd9013 > tools/scripts/lens-run-class.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/29391/diff/ > > > Testing > ------- > > - Ran the TestMLRunner > - build and ran the docker script > > > Thanks, > > sharad agarwal > >
