> On Dec. 25, 2014, 8 a.m., Jaideep dhok wrote: > > lens-server/src/main/java/org/apache/lens/server/LensServer.java, line 164 > > <https://reviews.apache.org/r/29416/diff/1/?file=800475#file800475line164> > > > > Is it likely that main thread has been interrupted or terminated by the > > shutdown hook runs? If thats the case we will not have a clean shutdown. > > > > We should put thisServer.stop inside the shutdown hook.
"interrupted or terminated by the shutdown hook runs?" -> by the time the shutdown hook runs - Jaideep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29416/#review66081 ----------------------------------------------------------- On Dec. 25, 2014, 7:54 a.m., Srikanth Sundarrajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29416/ > ----------------------------------------------------------- > > (Updated Dec. 25, 2014, 7:54 a.m.) > > > Review request for lens. > > > Bugs: LENS-163 > https://issues.apache.org/jira/browse/LENS-163 > > > Repository: lens > > > Description > ------- > > LensServer imports the following dependencies > > import sun.misc.Signal; > import sun.misc.SignalHandler; > > and this is being used to register essentially shutdownhook. > > ... > Signal.handle(new Signal("TERM"), new SignalHandler() { > > @Override > public void handle(Signal signal) { > ... > > We should use Runtime::addShutdownHook() instead. > > > Diffs > ----- > > lens-server/src/main/java/org/apache/lens/server/LensServer.java 66abbcd > > Diff: https://reviews.apache.org/r/29416/diff/ > > > Testing > ------- > > No new tests added. Existing tests ran alright. > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [0.937s] > [INFO] Lens .............................................. SUCCESS [3.139s] > [INFO] Lens API .......................................... SUCCESS [5.696s] > [INFO] Lens API for server and extensions ................ SUCCESS [3.089s] > [INFO] Lens Cube ......................................... SUCCESS [5:21.532s] > [INFO] Lens DB storage ................................... SUCCESS [28.502s] > [INFO] Lens Query Library ................................ SUCCESS [19.518s] > [INFO] Lens Hive Driver .................................. SUCCESS > [11:37.892s] > [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [2.718s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [36.736s] > [INFO] Lens Server ....................................... SUCCESS > [12:09.370s] > [INFO] Lens client ....................................... SUCCESS [54.261s] > [INFO] Lens CLI .......................................... SUCCESS [3:44.160s] > [INFO] Lens Examples ..................................... SUCCESS [0.534s] > [INFO] Lens Distribution ................................. SUCCESS [3.451s] > [INFO] Lens Client Distribution .......................... SUCCESS [2.473s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:36.809s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 37:11.229s > [INFO] Finished at: Thu Dec 25 12:43:50 IST 2014 > [INFO] Final Memory: 135M/801M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Srikanth Sundarrajan > >
