> On Dec. 27, 2014, 12:09 p.m., Laxman Ch wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java, line 
> > 163
> > <https://reviews.apache.org/r/29422/diff/4/?file=801695#file801695line163>
> >
> >     nit. few more sysouts missed to port to log

There are 266 occurences of System.out in Lens Code (Pasted below). We can park 
a new Jira to port them. Objective here was not to port them all but do a 
beginning to start removing them. Hence only ported a few of them. Thanks for 
bringing up the discussion though.


lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    
System.out.println("@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@");
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    
System.out.println("@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@");
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    
System.out.println("@@PERSISTENT_RESULT_TEST-------------");
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:      
System.out.println("@@ RESULT " + result);
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    
System.out.println("@@END_PERSISTENT_RESULT_TEST-------------");
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    
System.out.println("@@START_FINISHED_PURGED_RESULT_TEST-------------");
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:      
System.out.println("@@ RESULT " + result);
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    
System.out.println("@@END_FINISHED_PURGED_RESULT_TEST-------------");
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      
System.out.println("**Cube " + cube.getName() + " Out egdes");
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      
System.out.println("--Out Graph-Nodes=" + graph.size());
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:        
System.out.println(tab.getName() + "::" + graph.get(tab));
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    
System.out.println("**Dim only outgraph");
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    
System.out.println("--Out Graph-Nodes=" + dimOnlyOutGraph.size());
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      
System.out.println(tab.getName() + "::" + dimOnlyOutGraph.get(tab));
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      
System.out.println("**Cube " + cube.getName() + " In egdes");
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      
System.out.println("--In Graph-Nodes=" + graph.size());
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:        
System.out.println(tab.getName() + "::" + graph.get(tab));
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    
System.out.println("**Dim only Ingraph");
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    
System.out.println("--In Graph-Nodes=" + dimOnlyInGraph.size());
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      
System.out.println(tab.getName() + "::" + dimOnlyInGraph.get(tab));
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java:      
System.out.println("Rewritten HQL:" + hql);
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java:   
 // System.out.println(sinkOp.toString());
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:    
System.out.println();
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:      
System.out.println(" {");
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:          
System.out.println("NON ASTNode");
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:        
System.out.println();
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    
System.out.println("Test twodaysBack:" + twodaysBack);
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    
System.out.println("Test twoMonthsBack:" + twoMonthsBack);
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    
System.out.println("--" + label + "--AST--");
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    
System.out.println("--query- " + query);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java:  
    System.out.println("hql[" + i + "]:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java:    
//System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java:    
//System.out.println("Expected:" + expected);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java:
    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", 
"test", parts));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    
System.out.println("Non existing parts:" + 
rewrittenQuery.getNonExistingParts());
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    
System.out.println("Non existing parts:" + 
rewrittenQuery.getNonExistingParts());
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      
System.out.println("Union hql query:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      
System.out.println("union query:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    
System.out.println("Query With process time col:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    
System.out.println("Query With process time col:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    
System.out.println("Query With process time col:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    
System.out.println("Query With process time col:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    
System.out.println("Query With process time col:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    
System.out.println("Query With process time col:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    
System.out.println("@@ Joins disabled? " + 
testConf.get(CubeQueryConfUtil.DISABLE_AUTO_JOINS));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      
System.out.println("TestJoinPathTimeRange: " + context.toHQL());
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      
System.out.println("@@ hql: " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    
System.out.println("@@" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    
System.out.println("@@2 " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      
System.out.println("@@HQL " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    
System.out.println("##testDimAttributeQueryWithFact " + rewrittenQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      
System.out.println("@@ HQL = " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:
    System.out.println("HQL query:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:
    System.out.println("HQL query:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:
    System.out.println("HQL query:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:
    System.out.println("HQL query:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:
    System.out.println("HQL query:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println("###Actual order by:" + HQLParser.getString(orderby).trim());
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println("reconstructed clause ");
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println("reconstructed clause 2");
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println("reconstructed clause ");
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println("reconstructed clause 2");
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(whereStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(whereStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(whereStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(whereStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(whereStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(whereStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(whereStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println("RECONSTRUCTED0:" + reconstructed);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println("RECONSTRUCTED1:" + reconstructed);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println("RECONSTRUCTED2:" + reconstructed);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println("RECONSTRUCTED3:" + reconstructed);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println("genQuery1: " + genQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    
System.out.println("genQuery2: " + genQuery2);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("@@ " + source + " ==> " + target + " paths =");
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:      
System.out.println(++i + " " + jp.getEdges());
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("--Graph-Nodes=" + graph.size());
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:      
System.out.println(tab.getName() + "::" + graph.get(tab));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testAutoJoinResolverauto join HQL:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testAutoJoinResolver@@Resolved join chain:[" + 
getAutoResolvedFromString(rewrittenQu
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testAutoJoinResolverExpected1" + expectedClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testAutoJoinResolverActual1" + actualClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testAutoJoinResolverauto join HQL:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testAutoJoinResolver@@Resolved join chain:[" + 
getAutoResolvedFromString(rewrittenQu
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testAutoJoinResolverExpected2" + expectedClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testAutoJoinResolverActual2" + actualClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testPartialJoinResolver Partial join hql: " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("@Resolved join clause " + joinClause);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("@@Set join type to " + 
hconf.get(CubeQueryConfUtil.JOIN_TYPE_KEY));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testJoinTypeConf@@Resolved join clause1 - " + 
getAutoResolvedFromString(ctx));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("@@Set join type to " + 
hconf.get(CubeQueryConfUtil.JOIN_TYPE_KEY));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testJoinTypeConf@@Resolved join clause2 - " + 
getAutoResolvedFromString(ctx));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testPreserveTableAlias@@HQL:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testPreserveTableAlias@@Resolved join clause - " + 
getAutoResolvedFromString(ctx));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testDimOnlyQuery@@@HQL:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testDimOnlyQuery@@@Resolved join clause: " + 
getAutoResolvedFromString(ctx));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testDimOnlyQuery@@@HQL2:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("##1 hql " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("##1 " + getAutoResolvedFromString(context));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("##2 hql " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("##2 " + getAutoResolvedFromString(context));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("##3 hql " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("##3 " + getAutoResolvedFromString(context));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testAutoJoinResolverauto join HQL:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testAutoJoinResolver@@Resolved join chain:[" + 
getAutoResolvedFromString(rewrittenQu
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testDimOnlyJoinChainExpected1 : " + expectedClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testDimOnlyJoinChainActual1 : " + actualClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testAutoJoinResolverauto join HQL:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testAutoJoinResolver@@Resolved join chain:[" + 
getAutoResolvedFromString(rewrittenQu
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testDimOnlyJoinChainExpected1 : " + expectedClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testDimOnlyJoinChainActual1 : " + actualClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testAutoJoinResolverauto join HQL:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testAutoJoinResolver@@Resolved join chain:[" + 
getAutoResolvedFromString(rewrittenQu
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testDimOnlyJoinChainExpected1 : " + expectedClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    
System.out.println("testDimOnlyJoinChainActual1 : " + actualClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestMaxUpdateInterval.java:  
      System.out.println(pairs[i].toString());
lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java:  
  System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", 
"test", parts));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java:  
  System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", 
"test", parts));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java:  
  System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", 
"test", parts));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    
System.out.println("results:" + result);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    
System.out.println("results:" + result);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    
System.out.println("results:" + result);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    
System.out.println("results:" + result);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    
System.out.println("results:" + result);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    
System.out.println("results:" + result);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    
System.out.println("results:" + result);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java: 
   System.out.println("###");
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:
    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:
    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:
    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:
    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:
    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:
    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:
    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:
    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:
    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:
    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:
    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:
    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:
    System.out.println("HQL:" + hqlQuery);
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java: 
   System.out.println("###HADOOP_PATH " + 
System.getProperty("hadoop.bin.path"));
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java: 
   System.out.println("TestHiveDriver created");
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java: 
   System.out.println("Hadoop Location: " + 
System.getProperty("hadoop.bin.path"));
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java: 
   System.out.println("Hadoop Location: " + 
System.getProperty("hadoop.bin.path"));
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java: 
     System.out.println("Progress:" + 
ctx.getDriverStatus().getProgressMessage());
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java: 
     System.out.println("Error:" + ctx.getDriverStatus().getErrorMessage());
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java: 
     System.out.println("Status:" + ctx.getDriverStatus().getStatusMessage());
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java: 
         System.out.println("Actual:" + line);
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java: 
     System.out.println("#W Waiting for query " + ctx.getQueryHandle() + " 
status: "
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java: 
     System.out.println("Progress:" + 
ctx.getDriverStatus().getProgressMessage());
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java: 
   System.out.println("Tables:" + plan.getTablesQueried());
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java: 
   System.out.println("Parts:" + plan.getPartitions());
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:
    System.out.println("TestRemoteHiveDriver created");
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:
    System.out.println("@@@@ start_persistence_test");
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:
      System.out.println("@@ Adding partition " + i);
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:
    System.out.println("@@ partitions" + plan.getPartitions());
lens-driver-impala/src/test/java/org/apache/lens/driver/impala/it/ITImpalaDriver.java:
      System.out.println("Row1" + row);
lens-driver-impala/src/test/java/org/apache/lens/driver/impala/it/ITImpalaDriver.java:
      System.out.println("Row2" + row);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:
    System.out.println("Created table : " + table);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:
    System.out.println(joinTreeBeforeRewrite);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:
    System.out.println(joinTreeAfterRewrite);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:
    System.out.println(joinTreeBeforeRewrite);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:
    System.out.println(joinTreeAfterRewrite);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:
    System.out.println("default case: " + joinTreeAfterRewrite);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:
    System.out.println("Created table " + table);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:  
  System.out.println("Driver configured!");
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:  
  System.out.println("Driver closed!");
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:  
      System.out.println(rowObjects);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:  
      System.out.println(rowObjects);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java: 
     System.out.println("Error : " + ex);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java: 
   System.out.println("@@@ Test_execute_async:" + context.getQueryHandle());
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java: 
       System.out.println("@@@@ Query is complete " + handle);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java: 
     System.out.println("Query: " + handle + " Status: " + 
context.getDriverStatus());
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java: 
     System.out.println("Matched metadata");
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java: 
       System.out.println("Matched exception");
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java: 
     System.out.println("@@@@ QUERY " + (i + 1));
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java: 
   System.out.println("@@@ Submitting valid query");
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java: 
     System.out.println("@@@@ QUERY " + (i + 1));
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java: 
   System.out.println("@@@ Submitting query after pool quota used");
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java: 
   System.out.println("@@@ test_cancel:" + context.getQueryHandle());
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java: 
     System.out.println("Query: " + handle + " Status: " + 
ctx.getDriverStatus());
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:
      System.out.println("Adding partition from:dim1-local-part.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:
      System.out.println("Added partition from:dim1-local-part.xml");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:
      System.out.println("Adding partition from:dim2-local-part.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:
      System.out.println("Added partition from:dim2-local-part.xml");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:
      System.out.println("Adding partition from:dim4-local-part.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:
      System.out.println("Added partition from:dim4-local-part.xml");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:
      System.out.println("Created DB storages for dim_table3 and dim_table4");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:
      System.out.println("Creating DB storage failed for dim_table3 and 
dim_table4");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:
      System.out.println("Adding partition from:" + fileName + " failed");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:
      System.out.println("Added partition from:" + fileName);
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
  System.out.println("Creating cube from:sample-cube.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
  System.out.println("Creating dimension from:sample-dimension.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
  System.out.println("Creating dimension from:sample-dimension2.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
  System.out.println("Creating dimension from:sample-db-only-dimension.xml 
failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
  System.out.println("Creating storage from:" + fileName + " failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
  System.out.println("Creating dim table from: dim_table.xml and 
dim1-storage-tables.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
  System.out.println("Creating dim table from: dim_table2.xml and 
dim2-storage-tables.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
  System.out.println("Creating dim table from: dim_table3.xml and 
dim3-storage-tables.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
  System.out.println("Creating dim table from: dim_table4.xml and 
dim4-storage-tables.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
  System.out.println("Creating fact table from: fact1.xml and 
fact1-storage-tables.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
  System.out.println("Creating fact table from: fact2.xml and 
fact2-storage-tables.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
  System.out.println("Creating fact table from: rawfact.xml and 
rawfact-storage-tables.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
System.out.println("Created sample metastore!");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
System.out.println("Database:" + metastore.metaClient.getCurrentDatabase());;
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
System.out.println("Storages:" + metastore.metaClient.getAllStorages());;
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
System.out.println("Cubes:" + metastore.metaClient.getAllCubes());;
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
System.out.println("Dimensions:" + metastore.metaClient.getAllDimensions());;
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
System.out.println("Fact tables:" + metastore.metaClient.getAllFactTables());;
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      
System.out.println("Dimension tables:" + 
metastore.metaClient.getAllDimensionTables());
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:    
System.out.println("Successful queries " + success + " out of " + total + 
"queries");
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      
System.out.println("Query:" + query);
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      
System.out.println("Status:" + queryClient.getQuery().getStatus());
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      
System.out.println("Total time in millis:"
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      
System.out.println("Driver run time in millis:"
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:        
  System.out.println("Result:");
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:        
      System.out.println(StringUtils.join(row.getValues(), "\t"));
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:        
    System.out.println("Result stored at " + 
persistentQueryResult.getPersistedURI());
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      
System.out.println("--------------------");
lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java:    
System.out.println(builder.toString());
lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java:    
System.out.println(builder.toString());
lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java:      
System.out.println("@@@@ COL " + rc.getName() + " TYPE " + 
toHiveType(rc.getType()));
lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java:   
 System.out.println("Setup outputs done");
lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFilePersistentFormatter.java:
    System.out.println("Actual rows:" + actual);
lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFilePersistentFormatter.java:
    System.out.println("Actual rows:" + actual);
lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java:
        System.out.println("Application BasePath:" + basePath);
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    
System.out.println("Remote hive server started!");
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    
System.out.println("Lens services started!");
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    
System.out.println("Lens services stopped!");
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    
System.out.println("Remote hive server stopped!");
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    
System.out.println("Final report");
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    
System.out.println("Lens services stopped!");
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    
System.out.println("Lens services restarted!");
lens-server/src/test/java/org/apache/lens/server/TestIndexResource.java:    
System.out.println("target path:" + target.getUri());
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:        
System.out.println("Create databse not allowed in mode:" + mode);
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:        
System.out.println("Drop databse not allowed in mode:" + mode);
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:        
System.out.println("Launching query not allowed in mode:" + mode);
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java:    
System.out.println("### Test session restart");
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java:    
System.out.println("Session params:" + sessionParams.getElements());
lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java:   
 System.out.println("@@@@ " + target().path("index.html").getUri());
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java:
    System.out.println("ALL DBs:" + allDbs.getElements());
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java:
      System.out.println("Attributes:" + dim.getAttributes());
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java:   
 System.out.println("@@@ testQueryStatusLogger");
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java:   
     System.out.println("@@@@ Got Event: Type= " + event.getClass().getName() + 
" obj = " + event);
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java:    
System.out.println("@@ State = " + queryContext.getStatus().getStatus().name());
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:   
 System.out.println("%% " + failedQueries);
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:   
   System.out.println("%% query " + ctx.getQueryHandle() + " status:" + stat);
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:   
 System.out.println("%% " + metricsSvc.getTotalFailedQueries());
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:   
 // System.out.println("query JSON:" + responseJSON);
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:   
 System.out.println("query XML:" + queryXML);
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:   
 System.out.println("PERSISTED RESULT:" + presultset);
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:
    System.out.println("Session params:" + sessionParams.getElements());
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:
    System.out.println("Session params:" + sessionParams.getElements());
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:
    System.out.println("Session params:" + sessionParams.getElements());
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:
    System.out.println("Session params:" + sessionParams.getElements());
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:
      System.out.println("sessionParams:" + sessionParams.getElements());


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66178
-----------------------------------------------------------


On Dec. 27, 2014, 10:55 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 10:55 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle 
> aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console 
> appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j 
> logger. Added required dependencies in lens-cube/pom.xml to facilitate the 
> same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 
> fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS 
> [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Reply via email to