> On Dec. 27, 2014, 4:17 p.m., Suma Shivaprasad wrote: > > pom.xml, line 722 > > <https://reviews.apache.org/r/29445/diff/1/?file=801684#file801684line722> > > > > why do we need elasticsearch dep since we dont have any driver for the > > same? If not needed, can we remove this dep?
Its a very old dependency, not used anymore. We can remove it. Thanks for pointing it out. - Jaideep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29445/#review66190 ----------------------------------------------------------- On Dec. 27, 2014, 10:51 a.m., Laxman Ch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29445/ > ----------------------------------------------------------- > > (Updated Dec. 27, 2014, 10:51 a.m.) > > > Review request for lens. > > > Bugs: LENS-134 > https://issues.apache.org/jira/browse/LENS-134 > > > Repository: lens > > > Description > ------- > > LENS-134: Centralized version managements of dependencies and plugins > > - Moved all versions as properties in lens-parent > - Managed versions of all dependencies and plugins to lens-parent > > > laxman@laxman:~/working/code/incubator-lens$ grep "<version>" */pom.xml |grep > -v '${project.version}' |grep -v '2.0.0-SNAPSHOT' > checkstyle/pom.xml: <version>14</version> > checkstyle/pom.xml: <version>1.0-SNAPSHOT</version> > lens-api/pom.xml: > <version>${jaxb2.basics.plugin.version}</version> > > These 3 are can't be variables and can't be managed from parent pom. > > > Diffs > ----- > > checkstyle/pom.xml 22d7ccb > lens-api/pom.xml 0e17893 > lens-cli/pom.xml bcae761 > lens-client-dist/pom.xml 9485401 > lens-client/pom.xml f471d5f > lens-cube/pom.xml 1bcb4dc > lens-driver-hive/pom.xml a089717 > lens-driver-impala/pom.xml aaeb08b > lens-driver-jdbc/pom.xml c0d827d > lens-ml-lib/pom.xml cfde655 > lens-query-lib/pom.xml 4be4e3c > lens-server-api/pom.xml 9ced6ac > lens-server/pom.xml 4b58138 > lens-storage-db/pom.xml 0dc6461 > pom.xml 2c6a0e9 > > Diff: https://reviews.apache.org/r/29445/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.560s] > [INFO] Lens .............................................. SUCCESS [1.939s] > [INFO] Lens API .......................................... SUCCESS [6.541s] > [INFO] Lens API for server and extensions ................ SUCCESS [5.658s] > [INFO] Lens Cube ......................................... SUCCESS [7:04.018s] > [INFO] Lens DB storage ................................... SUCCESS [12.204s] > [INFO] Lens Query Library ................................ SUCCESS [5.406s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:07.266s] > [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [3.538s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [28.570s] > [INFO] Lens Server ....................................... SUCCESS [4:59.730s] > [INFO] Lens client ....................................... SUCCESS [23.254s] > [INFO] Lens CLI .......................................... SUCCESS [1:58.919s] > [INFO] Lens Examples ..................................... SUCCESS [1.350s] > [INFO] Lens Distribution ................................. SUCCESS [6.012s] > [INFO] Lens Client Distribution .......................... SUCCESS [8.228s] > [INFO] Lens ML Lib ....................................... SUCCESS [50.380s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:46.663s > [INFO] Finished at: Sat Dec 27 10:50:08 UTC 2014 > [INFO] Final Memory: 106M/775M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Laxman Ch > >
