> On Dec. 17, 2014, 10:05 a.m., Rajat Khandelwal wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java, > > line 789 > > <https://reviews.apache.org/r/29110/diff/2/?file=793599#file793599line789> > > > > SERVER_PFX + "query.rewriters"
fixed > On Dec. 17, 2014, 10:05 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/query/RewriteUtil.java, > > line 348 > > <https://reviews.apache.org/r/29110/diff/2/?file=793604#file793604line348> > > > > can just call getQueryRewriter, method is in the same class. fixed On Dec. 17, 2014, 10:05 a.m., Suma Shivaprasad wrote: > > Why do we need to move RewriteUtil to server? rewriteUtil is now doing rewrites for both cube and user DSL queries and doesnt belong to lens-cube logically. IMO i would have seperated out the cube specific part as well out of RewriteUtil before moving but since we have plans to remove the CUBE clause itself out of the grammar, didnt want to touch that part as part of this jira - Suma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29110/#review65305 ----------------------------------------------------------- On Dec. 29, 2014, 12:08 p.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29110/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2014, 12:08 p.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-24 > https://issues.apache.org/jira/browse/LENS-24 > > > Repository: lens > > > Description > ------- > > LENS-24 - Changes to plugin Query Rewriter > > > RewriteUtil changes > -> had 2 rewrite phases now - rewriteToCubeQL and rewriteToHQL > -> rewriteToHQL operates on getRewrittenQuery instead of getUserQuery() > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java > d2da97d > lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java > 796a582 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > cd1a0c7 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java > 9c17749 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > ce62b65 > lens-examples/src/main/resources/dim3-storage-tables.xml 213138a > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0ae539e > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > c1d4954 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java > 5dab13b > lens-server/pom.xml 55d5d58 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 9521136 > lens-server/src/main/java/org/apache/lens/server/query/RewriteUtil.java > PRE-CREATION > lens-server/src/main/resources/lensserver-default.xml 986c714 > > lens-server/src/test/java/org/apache/lens/server/query/DummyQueryRewriter.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 7edc3bc > lens-server/src/test/java/org/apache/lens/server/query/TestRewriting.java > PRE-CREATION > lens-server/src/test/resources/lens-site.xml ebf4ddb > src/site/apt/admin/config.apt e982b07 > > Diff: https://reviews.apache.org/r/29110/diff/ > > > Testing > ------- > > > Thanks, > > Suma Shivaprasad > >
