----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29452/#review66256 -----------------------------------------------------------
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java <https://reviews.apache.org/r/29452/#comment109627> Why only two? There is no guarantee that two filters are sufficient. On the other hand a single filter on a primary key is more than enough. - Jaideep dhok On Dec. 29, 2014, 9:57 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29452/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2014, 9:57 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-170 > https://issues.apache.org/jira/browse/LENS-170 > > > Repository: lens > > > Description > ------- > > Queries without filters are expensive to run using jdbc driver, such queries > can be answered only via hive. For a query to be answerable from jdbc > expected to have additional filters along with date. > > > Diffs > ----- > > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > 5b7f519 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > 5af6ead > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java > 9c17749 > > Diff: https://reviews.apache.org/r/29452/diff/ > > > Testing > ------- > > Fixed failing test cases. All unit tests are running fine. > > > Thanks, > > Sushil Mohanty > >
