----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29484/#review66361 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java <https://reviews.apache.org/r/29484/#comment109806> nit...newline to format seperate driver exceptions lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java <https://reviews.apache.org/r/29484/#comment109805> should we move this to Utils - Suma Shivaprasad On Dec. 30, 2014, 12:49 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29484/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2014, 12:49 p.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-179 > https://issues.apache.org/jira/browse/LENS-179 > > > Repository: lens > > > Description > ------- > > Gets the cause of the explain failure and fails if setting plan did not pass > for any driver > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java > 5dab13b > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 7edc3bc > > Diff: https://reviews.apache.org/r/29484/diff/ > > > Testing > ------- > > Updated unit test to assert for error message. Will do testing for some more > queries and update here. > > > Thanks, > > Amareshwari Sriramadasu > >
