> On Jan. 7, 2015, 1:03 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java, line > > 455 > > <https://reviews.apache.org/r/29504/diff/4/?file=808648#file808648line455> > > > > We need to check if this TODO is required
equivalent code was present earlier. and after the modification, no such pruning is done(yet). And the test cases are still passing. We can take it up in another jira. > On Jan. 7, 2015, 1:03 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java, > > lines 235-240 > > <https://reviews.apache.org/r/29504/diff/4/?file=808655#file808655line235> > > > > Any idea why the latest filter changes here? Not yet. But the older version looks wrong to me. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29504/#review67014 ----------------------------------------------------------- On Jan. 7, 2015, 12:22 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29504/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2015, 12:22 p.m.) > > > Review request for lens. > > > Bugs: LENS-88 > https://issues.apache.org/jira/browse/LENS-88 > > > Repository: lens > > > Description > ------- > > 1. Converted Map<Dimension,..> to Map<Aliased<Dimension>, ...> in allPaths, > and some more places > 2. Added merging of join chains into a data structure called JoinTree > 3. In the query, if only join chains are used, it will succeed. If join > chains are used along with direct dimensions, then if the direct dimensions > are either not part of any joinchain or if they are part of joinchains, then > they should be part of only one joinchain -- that too as an intermediate > table -- then only it'll go through. > 4. Some small typos. > 5. Added proper aliasing for intermediate tables of join chains. Will be > aliased only if a dimension is used in two joinchains. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java > 12909a749a0b170df721322ce9f16c1a808b9787 > lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java > b5a163151ee0944e7e25e1127f7d2e527b2cc2c0 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > e4987f3af5822a6121b851132dd8ce5ffc4cbb0e > lens-cube/src/main/java/org/apache/lens/cube/parse/Aliased.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > dfb07aa7391fb34c2778c6f34dde2dfaeb3ed999 > lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java > 306dd2b9ced93b3e3df31248392960fe8f6ec429 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 6767058692ba5e9262d5e56d1e698b914f641e67 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > dab3099750d5a1db4e5e9c70844cf0ed6367e596 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 956ff8462007d18193e7f32742e910c2b48791ec > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > ceba4623df92a6499ad1713ccb0b42f045f98785 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 9215d3816f15dce006cd4edea85194c0ee38790b > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 36c46fbef87c8a6e07533eb871408e37eb31cea5 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java > fcfe207685ff1a7b4cb16d85e720e4e1ebee48b3 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java > f8a4696f2e77ef5c0f40ad7ffea07ab0f480c623 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 0e414df1628a1108ffcd18315ae837a81c6a5de9 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 9ddc4546927785e05e3d23556402bd28cc6da2ec > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java > 173c458347e57c0fdaf95de57b805c4bd1c9822e > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > 7e51a826ed45ced6451ce6fa325aad164e603fc6 > > Diff: https://reviews.apache.org/r/29504/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.604s] > [INFO] Lens .............................................. SUCCESS [1.708s] > [INFO] Lens API .......................................... SUCCESS [6.185s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.189s] > [INFO] Lens Cube ......................................... SUCCESS [7:09.247s] > [INFO] Lens DB storage ................................... SUCCESS [12.234s] > [INFO] Lens Query Library ................................ SUCCESS [5.306s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:15.729s] > [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [3.968s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [28.337s] > [INFO] Lens Server ....................................... SUCCESS [4:57.788s] > [INFO] Lens client ....................................... SUCCESS [23.034s] > [INFO] Lens CLI .......................................... SUCCESS [1:58.528s] > [INFO] Lens Examples ..................................... SUCCESS [1.063s] > [INFO] Lens Distribution ................................. SUCCESS [5.440s] > [INFO] Lens Client Distribution .......................... SUCCESS [6.912s] > [INFO] Lens ML Lib ....................................... SUCCESS [48.288s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:53.627s > [INFO] Finished at: Fri Jan 02 15:19:32 UTC 2015 > [INFO] Final Memory: 112M/1136M > [INFO] > ------------------------------------------------------------------------ > > Need to add test cases for: > > > 1. Any other aliasing related test cases. > > > ***NOTE: Please review all the test cases changes carefully. Most are > regarding join order change but some are more than that. In some cases, the > old expected result didn't make sense to me so I installed the actual as > expected there. *** > > > Thanks, > > Rajat Khandelwal > >
