----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29705/#review67186 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java <https://reviews.apache.org/r/29705/#comment111051> We should not create a new configuration here. You should be property value from CubeQueryContext.getConf() lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java <https://reviews.apache.org/r/29705/#comment111052> isDistinctClauseUsed(cubeql.getSelectAST()) == false can be changed to !isDistinctClauseUsed(cubeql.getSelectAST()) lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java <https://reviews.apache.org/r/29705/#comment111054> We might have to check for node.getToken() != null here lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java <https://reviews.apache.org/r/29705/#comment111059> Can you add conf olap-query-conf.xml with description? lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java <https://reviews.apache.org/r/29705/#comment111058> Can you seperate this test into different method? Can you add queries with more than one column, and also queries passing distinct in themselves and with function distincts in that method? - Amareshwari Sriramadasu On Jan. 8, 2015, 10:35 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29705/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 10:35 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-169 > https://issues.apache.org/jira/browse/LENS-169 > > > Repository: lens > > > Description > ------- > > Currently dimension only queries give duplicate rows when joining with fact > for specified date range. For such queries we should be adding distinct > keyword in the projected column list. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 2d063ef > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > 8afaf17 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java > e24e0bc > > Diff: https://reviews.apache.org/r/29705/diff/ > > > Testing > ------- > > Tested this by adding new test case. All unit tests are running fine. > > > Thanks, > > Sushil Mohanty > >
