> On Jan. 9, 2015, 5:04 a.m., Amareshwari Sriramadasu wrote:
> > pom.xml, line 248
> > <https://reviews.apache.org/r/29706/diff/1/?file=812946#file812946line248>
> >
> >     Will this be applied for all modules?

Yes


> On Jan. 9, 2015, 5:04 a.m., Amareshwari Sriramadasu wrote:
> > lens-dist/pom.xml, line 103
> > <https://reviews.apache.org/r/29706/diff/1/?file=812944#file812944line103>
> >
> >     Will we need similar change in lens-client-dist also?

Depends on requirements. This change is only required, if we have a requirement 
to do maven variable substitutions while creating debian of lens-client-dist.


> On Jan. 9, 2015, 5:04 a.m., Amareshwari Sriramadasu wrote:
> > lens-dist/pom.xml, line 102
> > <https://reviews.apache.org/r/29706/diff/1/?file=812944#file812944line102>
> >
> >     Should we use the property defined for install directory?

Yes we should. Will make this change. Will also remove /usr/local/lens from 
other places in the same file as well.


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29706/#review67371
-----------------------------------------------------------


On Jan. 8, 2015, 11:12 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29706/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 11:12 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-181
> 
> Created postinst script for lens server debian.
> Added war-expansion functionality in postinst script.
> 
> 
> Diffs
> -----
> 
>   lens-dist/pom.xml f3c5463 
>   lens-dist/src/deb/control/postinst PRE-CREATION 
>   pom.xml 079971f 
>   tools/scripts/lens-config.sh 8bd9013 
> 
> Diff: https://reviews.apache.org/r/29706/diff/
> 
> 
> Testing
> -------
> 
> Debian installation successful.
> 
> root@34932e553229:/opt/lens# dpkg -i 
> lens-dist/target/lens-server_2.0.0-SNAPSHOT.deb 
> (Reading database ... 24319 files and directories currently installed.)
> Preparing to unpack .../lens-server_2.0.0-SNAPSHOT.deb ...
> Unpacking lens-server (2.0.0-SNAPSHOT) over (2.0.0-SNAPSHOT) ...
> Setting up lens-server (2.0.0-SNAPSHOT) ...
> /
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Reply via email to