----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29758/#review67399 -----------------------------------------------------------
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java <https://reviews.apache.org/r/29758/#comment111416> Fetch size set at result set retrieval will override this? If so, can you update the config doc with the same? lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java <https://reviews.apache.org/r/29758/#comment111417> From the code i see that the configuration is at driver level, but here it is query level. It may not be getting set with this. - Amareshwari Sriramadasu On Jan. 9, 2015, 9:18 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29758/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 9:18 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: lens-188 > https://issues.apache.org/jira/browse/lens-188 > > > Repository: lens > > > Description > ------- > > Added two new configs, one for fetch size and one to enable streaming result > sets. > > > Diffs > ----- > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 09f88d8 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java > 489af81 > lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 4f0acc7 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > ce62b65 > src/site/apt/admin/jdbcdriver-config.apt 54e5dd0 > > Diff: https://reviews.apache.org/r/29758/diff/ > > > Testing > ------- > > Added a unit test to validate streaming result set config works correctly. > > Validated existing tests in JDBC module. > > > Thanks, > > Jaideep dhok > >
