> On Jan. 4, 2015, 1:41 a.m., Amareshwari Sriramadasu wrote: > > Changes look fine. Can you also run examples, run a query from cli and > > check no runtime dependencies are removed? > > Laxman Ch wrote: > I have done full build (including Lens examples) and its passing. Please > let me know if that is not sufficient. > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS > [4.622s] > [INFO] Lens .............................................. SUCCESS > [3.270s] > [INFO] Lens API .......................................... SUCCESS > [10.048s] > [INFO] Lens API for server and extensions ................ SUCCESS > [10.883s] > [INFO] Lens Cube ......................................... SUCCESS > [7:23.075s] > [INFO] Lens DB storage ................................... SUCCESS > [11.785s] > [INFO] Lens Query Library ................................ SUCCESS > [5.898s] > [INFO] Lens Hive Driver .................................. SUCCESS > [3:17.240s] > [INFO] Lens Driver for Cloudera Impala ................... SUCCESS > [3.477s] > [INFO] Lens Driver for JDBC .............................. SUCCESS > [29.310s] > [INFO] Lens Server ....................................... SUCCESS > [5:07.928s] > [INFO] Lens client ....................................... SUCCESS > [21.777s] > [INFO] Lens CLI .......................................... SUCCESS > [1:57.254s] > [INFO] Lens Examples ..................................... SUCCESS > [0.929s] > [INFO] Lens Distribution ................................. SUCCESS > [4.594s] > [INFO] Lens Client Distribution .......................... SUCCESS > [7.256s] > [INFO] Lens ML Lib ....................................... SUCCESS > [47.022s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:28.042s > > Amareshwari Sriramadasu wrote: > Lens examples build does not run examples. We need to start server and > run examples. You can follow install and run steps for the same.
I verified running examples with the patch and verified cli as well. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29562/#review66586 ----------------------------------------------------------- On Jan. 3, 2015, 7:58 p.m., Laxman Ch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29562/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2015, 7:58 p.m.) > > > Review request for lens. > > > Bugs: LENS-173 > https://issues.apache.org/jira/browse/LENS-173 > > > Repository: lens > > > Description > ------- > > - Remove unused dependencies > - Organized/groupeed dependencies > - impala dependency related changes > > > Diffs > ----- > > lens-api/pom.xml 552fd62 > lens-driver-impala/pom.xml 5f24ff4 > lens-server/pom.xml cd4ccaf > pom.xml 079971f > > Diff: https://reviews.apache.org/r/29562/diff/ > > > Testing > ------- > > Done. Build is passing. > > > Thanks, > > Laxman Ch > >
